My Additions #319
My Additions #319
Conversation
Feel free to reject the gitignore one, i don't mind it, however, PsychFlxAnimate is nessacary as there are alot of compile errors that beg for it otherwise...
just kinda makes sense given we have one for every other instance
Makes it so the restart effect (minus changing difficulty) will now instead do something more accurate to the base game, i also made it so when you get shitty note ratings the notes desaturate and become more ghost like, not 100% accurate but it looks good
Made it so that when gray notes happen, they got the combo stuck at 1, fixed this Also added a setting to toggle this for those that don't think they should lose their combo doing this
lol whoops
Changed some of the credit icons to fit the artstyle of the other icons, i also added myself since i committed other assets, i did not touch lilys.
bleh bleh bleh, fixed my credits color also✈️
|
NOTE: this transition does not happen in charting mode (intentional) or when changing difficulties |
mikolka9144
left a comment
mikolka9144
left a comment
There was a problem hiding this comment.
There are some good additions, but also things I would like to wait with implementing.
Lastly, please split this PR into multiple smaller instead of bundling them as "My additions"
| ### VS Code | ||
| export/* | ||
| .vscode/* | ||
| ### Added just because its easier to manage with a folder like this for me ✌️ |
There was a problem hiding this comment.
What are we ignoring with this?
Like.. it feels so unnecessary here
There was a problem hiding this comment.
Usually i create backups of my code with this folder, as i use a external drive for the majority of my work, iirc i even said this one can not be added before pushing
| { | ||
| updateFollowDelta(elapsed); | ||
|
|
||
| var camName:String; |
There was a problem hiding this comment.
Generally there's only one main Psych camera (with likely some exceptions), so adding names as part of Psych API also feels unnecessary
| ['Mikolka9144', 'mikolka', 'The lead for the mod', 'https://gamebanana.com/members/3329541', '2ebcfa'], | ||
| [""], | ||
| ['P-Slice Contributors'], | ||
| ['CigsDev', 'cigsdev', 'Contributed code and assets', 'https://x.com/CigsDev', '744da1'], |
There was a problem hiding this comment.
You shouldn't be editing the credits list itself in a pull request.
There was a problem hiding this comment.
Noted then, in the future i wont
| option.onChange = onChangeHitsoundVolume; | ||
|
|
||
| var option:Option = new Option('Shit/Bad Ratings Cause a Combo Break', | ||
| "If checked, when you hit shit/bad, it'll cause your combo to go back to zero", |
There was a problem hiding this comment.
This option should also cause you to lose an FC state when saving it for the results screen.
| #end | ||
|
|
||
| //! Looping stuff | ||
| //*Coded by: CigsDev |
There was a problem hiding this comment.
You don't need to self-insert yourself like that. Git blame and commit history exist for that reason
There was a problem hiding this comment.
Yeah fair, i tend to do this alot and it's kinda a bad habbit
| public var discordRPC:Bool = true; | ||
| public var loadingScreen:Bool = true; | ||
| public var language:String = 'en-US'; | ||
| public var grayBreak:Bool = true; |
There was a problem hiding this comment.
Also this shouldn't be enabled by default as that might be confusing to people used to the way psych handles combo breaks.
There was a problem hiding this comment.
This is how it is in base v-slice though, albeit this is your engine, so feel free to change this
Made it so that when gray notes happen, they got the combo stuck at 1, fixed this Also added a setting to toggle this for those that don't think they should lose their combo doing this
|
i support this |
3 participants
Decided to go and code in a better(?) restart transition, i also added the fail notes for when you hit shit and bad ratings, this also includes general changes such as different credit icons (did not change lilys)
8mb.video-NmX-DB2qx7Hp.mp4