Added basic support for using * to match matte IDs in Fusion #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdeschenes
changed the title
Comment on lines
+912
to
+922
| if string.match(matte_name, "*") then | ||
| wildcard = string.gsub(matte_name, "*", ".*.?") | ||
| for crypto_name, __ in pairs(manifest) do | ||
| wildcard_match = string.match(crypto_name, wildcard) | ||
| if wildcard_match == crypto_name then | ||
| matte_id = manifest[crypto_name] | ||
| local matte_value = module._hex_to_float(matte_id) | ||
| matte_values[matte_value] = true | ||
| end | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
Looks like a solid idea you got there!
My only comment would be to isolate this wildcard solving logic and call it before using this function. Primary reason is to split responsibilities and keep things simple. One function to solve wildcards to their matched absolute results, and this function can stay as is considering the matte_names argument.
-- step #1: read matte list input
-- step #2: parse matte list input to proper list
-- step #3: solve wildcards
-- step #4: use existing code as is, enjoy life, proceedWDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small addition to the Fusion Cryptomatte plug-in to allow it to use asterisks (*) to make matches more flexible. We have been using it internally for awhile and found it pretty useful. It would be nice if it was natively included so we don't have to port it over for every update :)
This would let you write expressions such as: