PubxaiAnalyticsAdapter : Fix log collection logic#27
Open
Hrishi-Pubx wants to merge 3 commits intomasterfrom
Open
PubxaiAnalyticsAdapter : Fix log collection logic#27Hrishi-Pubx wants to merge 3 commits intomasterfrom
Hrishi-Pubx wants to merge 3 commits intomasterfrom
Conversation
- Introduced `refreshRank` to track auction refresh sequence - Improved bid and auction data preparation for sending to PubxAI
- Reset `refreshRank` to 0 when enabling analytics - Update test cases to reflect changes in event tracking order and beacon call count - Modify test expectations for URL paths and data sent to PubxAI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR fixes three critical issues in the PubxAI analytics adapter:
Improved Data Collection: Removes conditional filtering that was preventing some auction data from being collected by replacing
prepareSend()with a dedicatedprepareAuctionSend()function.Complete Winning Bid Collection: Adds a new
prepareSendWinningBids()function to properly capture all winning bids from auctions.Fixed Ad Server Targeting: Corrects the
getAdServerDataForBid()function to properly extract ad unit codes and handle missing GPT slots.The PR also includes minor code refactoring with better documentation.
Be sure to test the integration with your adserver using the Hello World sample page. -->
Other information