Merged
Conversation
- Deleted old splash images for various iPhone models to streamline asset management. - Removed the obsolete site manifest file. - Updated the HTML template to reflect the removal of the manifest link and added new favicon links. - Introduced new favicon images including a 96x96 PNG, SVG, and web app manifest for improved branding. - Ensured the manifest includes appropriate icon sizes and types for better compatibility across devices.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the UI with updated favicons, improved navigation styling, and corrected Fluent UI icon imports.
Changes:
- Replaced legacy favicon system with modern multi-format approach (SVG, ICO, PNG) and updated web manifest
- Enhanced navigation appearance with visible icons, updated hover states, and refined active state styling
- Updated Fluent UI icon imports to use explicit size-versioned imports (e.g.,
BuildingSkyscraper24Filledinstead ofBuildingSkyscraperFilled)
Reviewed changes
Copilot reviewed 9 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
server/views/_template.hbs |
Streamlined favicon links, removed device-specific splash screens, updated viewport meta tag with viewport-fit=cover |
server/public/sitemanifest.json |
Removed old manifest file (replaced by site.webmanifest) |
server/public/images/favicon/site.webmanifest |
Added new web manifest with maskable icons and updated branding |
server/public/images/favicon/*.png |
Added new favicon images in multiple sizes (96x96, 192x192, 512x512, apple-touch-icon) |
server/public/images/favicon/favicon.svg |
Added SVG favicon with dark mode support via CSS filter |
server/public/images/favicon/favicon.ico |
Updated ICO favicon |
server/public/images/favicon/*.png (deleted) |
Removed obsolete device-specific splash screen images and old favicon sizes |
server/public/images/favicon/safari-pinned-tab.svg |
Removed Safari pinned tab icon |
server/public/images/favicon/browserconfig.xml |
Removed legacy IE/Edge browser configuration |
server/public/css/app.css |
Added CSS custom properties for safe-area-insets to support notched devices |
client/theme/iconCatalog.ts |
Updated icon imports to use explicit size-versioned variants for consistency |
client/parts/Navigation/Navigation.module.scss |
Removed fixed width constraint, added margin and padding resets |
client/parts/Navigation/NavItem/NavItem.module.scss |
Made icons visible, updated styling with new colors, improved hover/active states with border highlighting |
client/components/Logo/Logo.module.scss |
Removed stroke styling from logo SVG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed favicons, better nav, updated icons