Skip to content

Conversation

@WyattBlue
Copy link
Member

sdist takes ~4MB of space, is neglected by PyPA, and is a bad experience for both the developer and the user. PyAV does not have universal support for every arch, and removing source builds in PyPI does not change that.

sdist takes ~4MB of space, is neglected by PyPA, and is a bad
experience for both the developer and the user. PyAV does not have
universal support for every arch, and removing source builds in
PyPI does not change that.
@WyattBlue WyattBlue merged commit 4f61921 into main Feb 16, 2025
8 checks passed
@WyattBlue WyattBlue deleted the patch branch February 16, 2025 21:45
@jlaine
Copy link
Member

jlaine commented Feb 21, 2025

Please roll this back, this is really dodgy. Some users have an explicit policy of not trusting binary wheels and they should absolutely be able to "pip install"!

@hmaarrfk
Copy link
Contributor

Hmm, looking through recent changes and flagged this one as suspicious too.

We use the pypi sources for conda-forge because often, different packages will have "generated files" that get uploaded to pypi but are not included in the github tags.

https://github.com/conda-forge/av-feedstock/blob/main/recipe/meta.yaml#L8

I'm also suspicious of the claim:

is neglected by PyPA,

People can in fact use the source, and this was recommended for exotic platforms:

image

It would be good if you gave some time for downstream to comment on these changes.

I've been quite active and I would have been able to give give this feedback before you pressed merge...

@WyattBlue
Copy link
Member Author

@hmaarrfk I say neglected because MANIFEST.in is such a goofy format now that pyproject.toml exists.

Anyway, I'll let @jlaine release 14.2.0 when he feels everything is in order.

@WyattBlue
Copy link
Member Author

Anyway, I'll let @jlaine release 14.2.0 when he feels everything is in order.

Retracted. jlaine is not talking to me at all. I've revered all objectionable changed, so I'm releasing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants