Skip to content

Set the default bit_rate to 0 #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyattBlue merged 1 commit into from
Feb 18, 2025
Merged

Set the default bit_rate to 0 #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions av/container/output.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ cdef class OutputContainer(Container):
codec_context.pix_fmt = lib.AV_PIX_FMT_YUV420P
codec_context.width = kwargs.pop("width", 640)
codec_context.height = kwargs.pop("height", 480)
codec_context.bit_rate = kwargs.pop("bit_rate", 1024000)
codec_context.bit_rate = kwargs.pop("bit_rate", 0)
codec_context.bit_rate_tolerance = kwargs.pop("bit_rate_tolerance", 128000)
try:
to_avrational(kwargs.pop("time_base"), &codec_context.time_base)
Expand All @@ -90,7 +90,7 @@ cdef class OutputContainer(Container):
# Some sane audio defaults
elif codec.type == lib.AVMEDIA_TYPE_AUDIO:
codec_context.sample_fmt = codec.sample_fmts[0]
codec_context.bit_rate = kwargs.pop("bit_rate", 128000)
codec_context.bit_rate = kwargs.pop("bit_rate", 0)
codec_context.bit_rate_tolerance = kwargs.pop("bit_rate_tolerance", 32000)
try:
to_avrational(kwargs.pop("time_base"), &codec_context.time_base)
Expand Down
2 changes: 0 additions & 2 deletions tests/test_encode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ def test_default_options(self) -> None:
assert stream.time_base is None

# codec context properties
assert stream.bit_rate == 1024000
assert stream.format.height == 480
assert stream.format.name == "yuv420p"
assert stream.format.width == 640
Expand Down Expand Up @@ -176,7 +175,6 @@ def test_default_options(self) -> None:
assert stream.time_base is None

# codec context properties
assert stream.bit_rate == 128000
assert stream.format.name == "s16"
assert stream.sample_rate == 48000

Expand Down
Loading