Add typing overloads for CodecContext.create
#1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaine
force-pushed
the
codec-typing
branch
2 times, most recently
from
bc3ceca to
8752b44
Compare
The return type of `CodecContext.create` can be narrowed based on the name of the requested codec, allowing us to know whether we are dealing with an `AudioCodecContext` or a `VideoCodecContext`. As the same logic is used by `OutputContainer.add_stream`, use a shared list of audio / video codec names. We add the following codec names: - audio : libopus, pcm_alaw, pcm_mulaw - video : libvpx, libx264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
CodecContext.createcan be narrowed based on the name of the requested codec, allowing us to know whether we are dealing with anAudioCodecContextor aVideoCodecContext.As the same logic is used by
OutputContainer.add_stream, use a shared list of audio / video codec names. We add the following codec names: