Skip to content

Fix segfault when accessing FilterContext after Graph object has left scope #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coredumped67 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −7
Open

Fix segfault when accessing FilterContext after Graph object has left scope #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions av/filter/context.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
cimport libav as lib

import weakref

from av.audio.frame cimport alloc_audio_frame
from av.dictionary cimport _Dictionary
from av.dictionary import Dictionary
Expand All @@ -17,7 +15,7 @@ cdef object _cinit_sentinel = object()

cdef FilterContext wrap_filter_context(Graph graph, Filter filter, lib.AVFilterContext *ptr):
cdef FilterContext self = FilterContext(_cinit_sentinel)
self._graph = weakref.ref(graph)
self._graph = graph
self.filter = filter
self.ptr = ptr
return self
Expand Down Expand Up @@ -79,10 +77,7 @@ cdef class FilterContext:

@property
def graph(self):
if (graph := self._graph()):
return graph
else:
raise RuntimeError("graph is unallocated")
return self._graph

def push(self, Frame frame):
cdef int res
Expand Down
Loading