Open
Conversation
Add substract() and main() functions
Add divide function and README.md
Add multiply function
IvanKozlov98
left a comment
IvanKozlov98
left a comment
There was a problem hiding this comment.
Привет, есть небольшие недочеты по коду, но, в целом, отличная работа!
Оценка:
За функции: 80/80 баллов
За README: 10/10 баллов
За коммиты и правильную структуру форков: 10/10
- 10 доп.
Итого: (100+10)/100 баллов
| @@ -0,0 +1,59 @@ | |||
| # функция для расчёта суммы двух чисел | |||
| def add(a, b): | |||
There was a problem hiding this comment.
названия переменных как-то должны подчеркивать -- что это числа - a,b - могут быть в теории чем угодно. Самое близкое к желаемому num1, num2
Comment on lines
+11
to
+12
| if b == 0: | ||
| return "Внимание! Делитель равен 0! Замените делитель!" |
There was a problem hiding this comment.
Пусть программа сама упадет с ошибкой, ошибки это здорово и их за этим и придумали :)
|
|
||
| # функция для расчета произведения двух чисел | ||
| def multiply(a, b): | ||
| return a*b |
There was a problem hiding this comment.
операнды в математических операциях принято разделять запятыми
Suggested change
| return a*b | |
| return a * b |
Comment on lines
+29
to
+31
| if len(arguments) != 3: | ||
| print("Ошибка ввода! Пробелы перед и после знака оператора, потом жмём Enter") | ||
| return |
There was a problem hiding this comment.
отлично!
пользователям не стоит доверять!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.