fix the bug by taking the style directly from sns #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickleonardy
requested review from
joostneuj,
pedromani,
pietrodantuono and
sam0per
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib styles bug fix
❗ Is the last change acceptable or will this break stuff? ❗
Changes made
with plt.style.context("seaborn-whitegrid"):-->with sns.axes_style("whitegrid")with plt.style.context("seaborn-ticks"):-->with sns.axes_style("ticks")How does the solution address the problem
By setting the styles directly with
sns.set_themewe access the styles directly and do not rely on matplotlib to be up-to-date / have the same naming as we have in our code.Additional thoughts
By setting the styles directly with
sns.axes_styleLinked issues
resolves #184