Wallets should use V6 after NU7 #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…and ψ inputs to DeriveNullifier must be consistent with the note committed to by cm. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@katava.local>
because it isn't relevant. Signed-off-by: Daira-Emma Hopwood <daira@katava.local>
…utgoing Viewing Key (Sapling and Orchard)". Also update the protocol spec references for ZIPs that referenced this section or the corresponding one for IVKs (ZIPs 212, 216, 231, 307, and 311). fixes zcash#740 Signed-off-by: Daira-Emma Hopwood <daira@katava.local>
pattern that we are going to use for Sapling and Orchard decryption, with an ExtractNote function that parses and checks the decrypted note. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…ttle lighter, for better contrast. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
… and Guy Rothblum for contributions to the science of zero-knowledge proving systems. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
for Orchard: the Merkle path should be from
$\mathsf{Extract}^{\mathbb{P}}(\mathsf{cm^{old}})$ rather than
$\mathsf{cm^{old}}$. This was implemented as intended in the `orchard`
crate. fixes zcash#1010
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…that "most Zcash wallets", not just zcashd, derive Sapling and Orchard keys and addresses according to ZIP 32. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
in \crossref{addressesandkeys}, saying that the derivations of
$\mathsf{ask}$ and $\mathsf{rivk}$ shown there are not the only
possibility, and referencing \crossref{orchardkeycomponents}.
Remove the corresponding change from `draft-ecc-quantum-recoverability`,
since it is not dependent on that proposal.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
to hex. Remove the corresponding change from `draft-ecc-quantum-recoverability`, since it is not dependent on that proposal. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
defining $\mathsf{AllowedLeadBytes}$ in \crossref{noteptconcept}.
Remove the corresponding changes from `draft-ecc-quantum-recoverability`,
since they are not dependent on that proposal.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
ZIP 0: Define a Change History section and Last-Updated field for ZIPs
…{decryptovk}:
$\mathsf{ToScalar}$ returns an integer, not a byte sequence, and so cannot
be assigned to $\underline{\mathsf{rcm}}$. The implementation in the
`zcash_note_encryption` crate was correct.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
…ring has already been done in this branch, so remove the paragraph suggesting that. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
(`.md` or `.rst`), and regularize the format of section references. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ZIP 0: Process changes to reduce the overhead of updating ZIP drafts
[Protocol spec] Refactor note decryption, and other fixes
delay. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
wallets-should-use-v6-after-nu7
branch
from
7b9ddab to
243ce6d
Compare
…mance requirements. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Author
|
zcash#1121 has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a local draft of the upstream zcash#1121 in order to view the rendered versions.