Refactor of ZIP 228 #128
Merged
Refactor of ZIP 228 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulLaux
approved these changes
Nov 20, 2025
zips/zip-0228.rst
Outdated
|
|
||
| We protect against the malleation of the ``timeLimit`` field by a malicious matching party by including the time limit inside the Action Group Hash that is signed using the Spend Authorization Signature (see more details in `Rationale for Time Limit`_). | ||
| The security of the Spend Authorization Signature and the collision resistance of the BLAKE2b-256 hash then ensures that the time limit remains the same as the one mandated by the creator of the Swap Order. | ||
| We protect against the malleation of the ``nAGExpiryHeight`` field by a malicious matching party by including the expiry height inside the Action Group Hash that is signed using the Spend Authorization Signature (see more details in `Rationale for Expiry Height`_). |
Author
There was a problem hiding this comment.
Yes, see ZIP 246: T.4a.v in the spec, and this line in the orchard implementation:
https://github.com/QED-it/orchard/blob/a02fdf1f873d58167887abe23a8a7e0b9c1a0a36/src/primitives/orchard_primitives_zsa.rs#L108
Author
There was a problem hiding this comment.
I noticed there is a change needed in the sentence though, need to replace Action Group Hash with v1 Signature Digest. Made this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes through ZIP 228, and makes changes to reconcile the ZIP with the updates made in ZIP 226, ZIP 227, ZIP 230 and ZIP 246, for the NU7 protocol upgrade