Rewriting orchard_digest and orchard_action_groups_digest spec for clarity
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulLaux
reviewed
Nov 17, 2025
PaulLaux
approved these changes
Nov 18, 2025
Author
|
We closed the upstream PR zcash#1130 on discussion with the ZIP editors (see zcash#1130 (comment)). Closing this PR as well as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it clear that we perform the
orchard_action_groups_digestfor each Action Group, and we concatenate the results for each Action Group at theorchard_digestlevel.This has now been opened as zcash#1130 to the upstream repository.