[Swaps] Update to the way the Spend Authorization Signature is calculated. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thSig is computed
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulLaux
reviewed
Oct 7, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
I will not approve it for now. Let's use this PR to make the changes we discussed today.
(actionGroupHash and SigHash)
vivek-arte
force-pushed
the
spendauthsig_msg_update
branch
from
e46583e to
cd278cb
Compare
vivek-arte
force-pushed
the
swaps_fees_reword
branch
from
d68094e to
55807eb
Compare
Author
|
I am merging these changes into #63 in order to combine these two PRs into a single one for review. |
vivek-arte
added a commit
that referenced
this pull request
Jun 9, 2025
…ated. (#73) This changes the Spend Authorization Signature to use the `orchard_action_groups_digest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Spend Authorization Signature to use the SIGHASH as before.