include matplotlib.pyplot as plt #4447
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
…4421) In the documentation, multiple objects of a class were sometimes referred to using the style "`MyClass`s". This PR updates these references to "`MyClass` objects" to fix translation problems in documentation. This addresses the part of #2067 for `/guides`. --------- Co-authored-by: abbycross <across@us.ibm.com>
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| "metadata": {}, | ||
| "source": [ | ||
| "To view execution span information, review the metadata of the result returned by `SamplerV2`, which comes in the form of an `ExecutionSpans` object. This object is a list-like container containing subclass instances of `ExecutionSpan`s such as `SliceSpan`:" | ||
| "To view execution span information, review the metadata of the result returned by `SamplerV2`, which comes in the form of an `ExecutionSpans` object. This object is a list-like container containing instances of subclasses of `ExecutionSpan`, such as `SliceSpan`:" |
There was a problem hiding this comment.
| "To view execution span information, review the metadata of the result returned by `SamplerV2`, which comes in the form of an `ExecutionSpans` object. This object is a list-like container containing instances of subclasses of `ExecutionSpan`, such as `SliceSpan`:" | |
| "To view execution span information, review the metadata of the result returned by `SamplerV2`, which comes in the form of an `ExecutionSpans` object. This object is a list-like container containing instances of subclasses of `ExecutionSpan`, such as `SliceSpan`:" |
| } | ||
| ], | ||
| "source": [ | ||
| "# Include the two commented-out lines if you are not using Python in a Jupyter notebook\n", |
There was a problem hiding this comment.
Hot take: what do you think about duplicating the comment? I find instructions get confusing when spread out over too many lines, like "wait which lines?" Ack that it could be overkill here though because we have so few lines
Actually, maybe better idea: move the import right before plt.show(), so the two line are right next to each other. Imports don't technically have to be at the very top of the file. (Although this may make a linter mad).
There was a problem hiding this comment.
Good points! Yet another option would be to be very explicit as to what to do, as in: "Uncomment lines x and y...". I wouldn't like to refer to specific line numbers in "normal" code, but a web snippet is another thing.
5 participants
Closes #4437
Also brings in changes by external contributor in #4421 - including here so that checks will pass