Conversation
…ng physical measurement ids
… MeasureIDAnalysis
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…asurementobservables-to-user-output-of-kernel
johnzl-777
approved these changes
Feb 3, 2026
Contributor
johnzl-777
left a comment
johnzl-777
left a comment
There was a problem hiding this comment.
LGTM! Once you get it merged in I'll merge it into #630 and have that ready for review too.
Comment on lines
374
to
376
| O0 = squin.set_observable([m0[0], m0[1]], 0) | ||
| m1 = squin.broadcast.measure(q) | ||
| O1 = squin.set_observable([m1[0], m1[1]], 1) |
Contributor
There was a problem hiding this comment.
Is there a reason that you decided to use capital "O" as the prefix for observable-related variables?
No problem on my end, just curious if there was some specific motivation for it
…asurementobservables-to-user-output-of-kernel
weinbe58
deleted the
phil/697-dataflow-analysis-to-map-detectormeasurementobservables-to-user-output-of-kernel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I implement logic that handes the propagation and tracking of observables and detectors through the
MeasurementIDAnalysis. In top of that I also refactor the gemini submodule and made the number of physical qubits in the logical qubit measurement explicit. After that I also updated the logic in theMeasurementIDAnalysisto handle the conversion from logical to physical measurements.