[173-support-4x2-and-2x4-mode-in-hdawg] #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to allow other AWG core <-> channel grouping modes. Aslo unit-tests fixed.
…nto 173-support-no-zhinst-toolkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the HDAWG driver to allow other AWG core <-> channel grouping modes. Also unit-tests fixed.
This ticket is still using the same "old" zhinst packages as before, and not the new "toolkit" packages. The ticket turned out to be quite large when doing together with the refactoring to use the toolkit packages, so it is now split into two.
A couple of TODO:s are remaining related to the "open" and "close" as it is not clear to me if only checking the state of the currently selected AWG core index in the
awg_moduleis enough when the instrument is in another grouping mode than 1x8. If you have some comments on that, I would like to hear it.