Correct ordering of qubits in QuEST state_result handling #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloAndresCQ
left a comment
PabloAndresCQ
left a comment
There was a problem hiding this comment.
Thanks Jake, this makes sense!
You mentioned that CI is failing due to a known issue with guppy result array comprehension. I don't know what's the better way to go around that, so I'll leave it for someone else to hit approve.
jake-arkinstall
force-pushed
the
fix/state-result-qubit-ordering
branch
from
1f14338 to
0de0d33
Compare
Collaborator
Author
|
I've rebased on main with the temporary fix (pinning guppylang) now, so CI should be green lights all the way |
ss2165
approved these changes
Jan 8, 2026
jake-arkinstall
pushed a commit
that referenced
this pull request
Jan 8, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.7](selene-sim-v0.2.6...selene-sim-v0.2.7) (2026-01-08) ### Features * Add event hook which records measurement results ([#104](#104)) ([01300ee](01300ee)), closes [#103](#103) * Correct qubit ordering in QuEST state dumping ([#110](#110)), closes [#109](#110) * Support state-dump passthrough on quantum replay simulator ([#108](#108)) ([1b01a01](1b01a01)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109.
The original implementation filtered qubits by presence in the user_specified list, but neglected to use the ordering of that list to append qubits in the right order. This PR fixes that by finding the index in the list, and inserting the qubit ID into that position within the (now pre-allocated)
permutation_rhslist.