[ENH] Spectral Series: visual parameter adjustment#830
Open
borondics wants to merge 2 commits intoQuasars:masterfrom
Open
[ENH] Spectral Series: visual parameter adjustment#830borondics wants to merge 2 commits intoQuasars:masterfrom
borondics wants to merge 2 commits intoQuasars:masterfrom
Conversation
markotoplak
changed the title
Collaborator
|
Why didn't you reuse |
Member
Author
|
This is yet another different type plot, so I am not sure whether to reuse either one of those now and change it in the future or make a new one and change it according to the plot requirements. It would be nice to have only one and reuse it, but I am not sure if we can generalize everything. What do you think? |
Collaborator
|
If current functionality can be supported by importing, I'd import. And then worry about extensions later. |
Member
Author
|
If #839 is merged, we can delete this. |
Collaborator
|
Feri, this is a different PR, this is some other plot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been missing since now - now I copy-pasted it from
Spectra. I think we probably said that we will make it work at some point.InteractiveViewBoxfrom theSpectrawidget to provide more interactive zooming?