Skip to content

Skip unecessary event#778

Merged
marmarek merged 1 commit intoQubesOS:mainfrom
ben-grande:skip-unecessary-event
Feb 7, 2026
Merged

Skip unecessary event#778
marmarek merged 1 commit intoQubesOS:mainfrom
ben-grande:skip-unecessary-event

Conversation

@ben-grande
Copy link
Contributor

This is a continuation of #775, I just want to run OpenQA on it to know if it breaks things. Also to not mix with the other PR so it can be merged faster.

@ben-grande
Copy link
Contributor Author

PipelineRetryFailed

@ben-grande
Copy link
Contributor Author

RTD blocking running tests:

Read the Docs build information
Build id: 31105772
Project: qubes-core-admin
Version: 778
Commit: a6e8a0d2d5c53b5023398d44c8fbd7773c98f60d
Date: 2026-01-22T14:31:30.219941Z
State: finished
Success: False


[rtd-command-info] start-time: 2026-01-22T14:31:30.731266Z, end-time: 2026-01-22T14:32:10.353927Z, duration: 39, exit-code: 128
git clone --depth 1 https://github.com/QubesOS/qubes-core-admin.git .
Cloning into '.'...
remote: Internal Server Error
fatal: unable to access 'https://github.com/QubesOS/qubes-core-admin.git/': The requested URL returned error: 500

Because Github is replying 500 to RTD. Documentation build should not have come before.

@marmarek
Copy link
Member

marmarek commented Feb 3, 2026

This has a conflict now.

@ben-grande ben-grande closed this Feb 4, 2026
@ben-grande ben-grande force-pushed the skip-unecessary-event branch from a6e8a0d to fb347b2 Compare February 4, 2026 10:14
@ben-grande ben-grande reopened this Feb 4, 2026
@ben-grande
Copy link
Contributor Author

PipelineRetry

Mixins are loaded to other classes, which means that these events are
called on a varied number of qubes even when it is unnecessary.
@ben-grande ben-grande force-pushed the skip-unecessary-event branch from fb347b2 to 4bb6e66 Compare February 5, 2026 16:08
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.10%. Comparing base (bb52c10) to head (4bb6e66).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/mix/net.py 57.14% 3 Missing ⚠️
qubes/vm/mix/dvmtemplate.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   70.17%   70.10%   -0.08%     
==========================================
  Files          61       61              
  Lines       13977    13994      +17     
==========================================
+ Hits         9808     9810       +2     
- Misses       4169     4184      +15     
Flag Coverage Δ
unittests 70.10% <70.58%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Feb 5, 2026

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020704-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update

  • system_tests_network

  • system_tests_guivm_gui_interactive

    • collect_logs: wait_serial (wait serial expected)
      # wait_serial expected: qr/JrqaX-\d+-/...

    • collect_logs: Failed (test died + timed out)
      # Test died: command 'curl --form upload=@journalctl.log --form upn...

    • collect_logs: wait_serial (wait serial expected)
      # wait_serial expected: qr/lqE1a-\d+-/...

  • system_tests_basic_vm_qrexec_gui_xfs

    • TC_20_NonAudio_whonix-gateway-18-pool: test_000_start_shutdown (error)
      subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...
  • system_tests_gui_tools

    • qubesmanager_manager: unnamed test (unknown)
    • qubesmanager_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qube-manager-dom0-log...

Failed tests

7 failures
  • system_tests_network

  • system_tests_guivm_gui_interactive

    • collect_logs: wait_serial (wait serial expected)
      # wait_serial expected: qr/JrqaX-\d+-/...

    • collect_logs: Failed (test died + timed out)
      # Test died: command 'curl --form upload=@journalctl.log --form upn...

    • collect_logs: wait_serial (wait serial expected)
      # wait_serial expected: qr/lqE1a-\d+-/...

  • system_tests_basic_vm_qrexec_gui_xfs

    • TC_20_NonAudio_whonix-gateway-18-pool: test_000_start_shutdown (error)
      subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...
  • system_tests_gui_tools

    • qubesmanager_manager: unnamed test (unknown)
    • qubesmanager_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qube-manager-dom0-log...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/166096#dependencies

31 fixed
  • system_tests_network

  • system_tests_pvgrub_salt_storage

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.grub failed (exit code 1), details reported...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_41_HVMGrub_fedora-42-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-42-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_gui_interactive

    • collect_logs: wait_serial (wait serial expected)
      # wait_serial expected: qr/m~uU4-\d+-/...

    • collect_logs: Failed (test died + timed out)
      # Test died: command 'curl --form upload=@journalctl.log --form upn...

  • system_tests_network_ipv6

  • system_tests_network_updates

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.dom0_update failed (exit code 1), details r...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_00_Dom0Upgrade_whonix-gateway-18: test_000_update_salt (failure)
      ?[0;31mDuration: 139139.863 ms?[0;0m... ?[0;31m Changes: ?[0;0m

  • system_tests_dispvm

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.dispvm failed (exit code 1), details report...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_DispVM_whonix-workstation-18: test_015_preload_race_more (error)
      raise TimeoutError from exc_val... TimeoutError

  • system_tests_guivm_vnc_gui_interactive

    • guivm_manager: unnamed test (unknown)

    • guivm_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'menu-qubes-tools' mat...

    • guivm_manager: wait_serial (wait serial expected)
      # wait_serial expected: qr/yp0HG-\d+-/...

  • system_tests_audio

    • system_tests: Fail (unknown)
      Tests qubes.tests.integ.audio failed (exit code 1), details reporte...

    • system_tests: Failed (test died)
      # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...

    • TC_20_AudioVM_PipeWire_whonix-workstation-18: test_260_audio_mic_enabled_switch_audiovm (failure)
      AssertionError: Failed to get mic attach/detach status!

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: wait_serial (wait serial expected)
      # wait_serial expected: qr/D8rIe-\d+-/...

    • whonixcheck: Failed (test died + timed out)
      # Test died: command 'qvm-run -ap whonix-gateway-18 'LC_ALL=C whon...

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants