Skip to content

Updates to aliased action and translation create dialogs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ImRodry wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updates to aliased action and translation create dialogs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b81e22
Added default values for translations
ImRodry Jan 9, 2021
3bb1e6b
Updated more default values
ImRodry Jan 9, 2021
6b5a71c
Add aliased action rename alert
ImRodry Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/AliasedActionCreateDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,13 @@
</VCol>
</VRow>
</VForm>
<VAlert
type="warning"
v-if="initialAliasedActionKey && formAliasedActionKey !== initialAliasedActionKey"
>
Screens and Buttons reference Aliased Actions by their key. You should
not change an Aliased Action's key unless you know what you are doing.
</VAlert>
<div class="action-btns lower-action-btns">
<VBtn class="cancel-btn" @click="cancelClicked">
Cancel
Expand Down Expand Up @@ -185,7 +192,7 @@ export default {
},
initialActionArg: {
type: String,
default: "/play "
default: "play "
},
initialHypixelBuildTeamAdminOnly: {
type: Boolean,
Expand Down Expand Up @@ -287,7 +294,7 @@ export default {
!this.formActionArg &&
this.formActionType === "SendChatCommandAction"
) {
this.formActionArg = "/play ";
this.formActionArg = "play ";
} else {
this.formActionArg = "";
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/AliasedActionsTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default {
editorInitialVisibleValue: true,
editorInitialAdminOnlyValue: false,
editorInitialActionType: "SendChatCommandAction",
editorInitialActionArg: "/play ",
editorInitialActionArg: "play ",
editorInitialHypixelPackageRankRegex: "",
editorInitialHypixelRankRegex: "",
editorInitialHypixelLocrawRegex: "",
Expand Down Expand Up @@ -137,7 +137,7 @@ export default {
this.editorInitialVisibleValue = true;
this.editorInitialAdminOnlyValue = false;
this.editorInitialActionType = "SendChatCommandAction";
this.editorInitialActionArg = "/play ";
this.editorInitialActionArg = "play ";
this.editorInitialHypixelRankRegex = "";
this.editorInitialHypixelPackageRankRegex = "";
this.editorInitialHypixelLocrawRegex = {};
Expand Down
4 changes: 2 additions & 2 deletions src/components/TranslationCreateDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ export default {
},
initialTranslationKey: {
type: String,
default: ""
default: "quickplay.games."
},
initialTranslationLang: {
type: String,
default: ""
default: "en_us"
},
initialTranslationValue: {
type: String,
Expand Down