-
-
Notifications
You must be signed in to change notification settings - Fork 33
Redesign stats menu #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Redesign stats menu #343
Conversation
supersaiyansubtlety
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new dialog looks great, thanks for this!
It's much easier to get an idea of the state of things with the information presented visually.
Just a few nitpicks and some size/scale issues.
The settings button get misaligned if you resize the window
It should probably stay at the bottom, or disabling resizing is probably fine, too.
Not everything scales
Scaling is missing for:
- the "Active Settings" label
- the overall percentage
- the corner radius of individual progress bars
| 50% | 100% | 200% |
|---|---|---|
![]() |
![]() |
![]() |
enigma-swing/src/main/java/org/quiltmc/enigma/gui/dialog/stats/StatProgressBar.java
Outdated
Show resolved
Hide resolved
enigma-swing/src/main/java/org/quiltmc/enigma/gui/dialog/stats/StatProgressBar.java
Outdated
Show resolved
Hide resolved
enigma-swing/src/main/java/org/quiltmc/enigma/gui/dialog/stats/StatTableModel.java
Outdated
Show resolved
Hide resolved
supersaiyansubtlety
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found another issue with resizing (shrinking) the dialog:

Making the scroll pane fill BOTH and giving it non-zero y weight partially fixes it:

But it still has a vertical scroll bar despite having empty space below it; I think the overall stat bar circle is taking up space even though it's not being rendered.



Closes #283