Open
Conversation
Project structure: - Move include files to include/hashsigs-cpp. This is more standard. Header files are then included with the 'hashsigs-cpp' prefix, e.g., "hashsigs-cpp/keccak.h". - Move resource files folder to res. - Rename test_vectors folder to res/vectors. - Add docs folder and Doxyfile.in (empty). CMakeLists.txt files: - Add BUILD_DOCS option. - Add fmt dependency. - Add a Preprocessing section to generate resources.hpp from resources.hpp.in. This file contains a static variable that holds the absolute path of the resources folder. - Change include_directories to target_include_directories. - Move GTest and json dependencies to tests/CMakeLists.txt. This is the only place where they are used. Bug fixing: - Make resource files folder accessible via an absolute path. Then use it from wotsplus_tests.cpp. This way, hashsigs_test can be run from anywhere.
Project structure: - Move include files to include/hashsigs-cpp. This is more standard. Header files are then included with the 'hashsigs-cpp' prefix, e.g., "hashsigs-cpp/keccak.h". - Move resource files folder to res. - Rename test_vectors folder to res/vectors. - Add docs folder and Doxyfile.in (empty). CMakeLists.txt files: - Add BUILD_DOCS option. - Add fmt dependency. - Add a Preprocessing section to generate resources.hpp from resources.hpp.in. This file contains a static variable that holds the absolute path of the resources folder. - Change include_directories to target_include_directories. - Move GTest and json dependencies to tests/CMakeLists.txt. This is the only place where they are used. Bug fixing: - Make resource files folder accessible via an absolute path. Then use it from wotsplus_tests.cpp. This way, hashsigs_test can be run from anywhere.
Project structure: - Move include files to include/hashsigs-cpp. This is more standard. Header files are then included with the 'hashsigs-cpp' prefix, e.g., "hashsigs-cpp/keccak.h". - Move resource files folder to res. - Rename test_vectors folder to res/vectors. - Add docs folder and Doxyfile.in (empty). CMakeLists.txt files: - Add BUILD_DOCS option. - Add fmt dependency. - Add a Preprocessing section to generate resources.hpp from resources.hpp.in. This file contains a static variable that holds the absolute path of the resources folder. - Change include_directories to target_include_directories. - Move GTest and json dependencies to tests/CMakeLists.txt. This is the only place where they are used. Bug fixing: - Make resource files folder accessible via an absolute path. Then use it from wotsplus_tests.cpp. This way, hashsigs_test can be run from anywhere.
Project structure: - Move include files to include/hashsigs-cpp. This is more standard. Header files are then included with the 'hashsigs-cpp' prefix, e.g., "hashsigs-cpp/keccak.h". - Move resource files folder to res. - Rename test_vectors folder to res/vectors. - Add docs folder and Doxyfile.in (empty). CMakeLists.txt files: - Add BUILD_DOCS option. - Add fmt dependency. - Add a Preprocessing section to generate resources.hpp from resources.hpp.in. This file contains a static variable that holds the absolute path of the resources folder. - Change include_directories to target_include_directories. - Move GTest and json dependencies to tests/CMakeLists.txt. This is the only place where they are used. Bug fixing: - Make resource files folder accessible via an absolute path. Then use it from wotsplus_tests.cpp. This way, hashsigs_test can be run from anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project structure:
include/hashsigs-cpp. This is more standard. Header files are then included with thehashsigs-cppprefix, e.g.,hashsigs-cpp/keccak.h.res.test_vectorsfolder tores/vectors.docsfolder andDoxyfile.in(empty). To avoid breaking compilation.CMakeLists.txt files:
BUILD_DOCSoption. Disabled by default. To avoid building docs all the time.fmtdependency. Not used at the moment but very helpful for upcoming PRs.resources.hppfromresources.hpp.in. This file contains a static variable that holds the absolute path of the resources folder.include_directoriestotarget_include_directories. Recommended practice.GTestandjsondependencies totests/CMakeLists.txt. This is the only place where they are used.Bug fixing:
hashsigs_testcan be run from anywhere.