Open
Conversation
rusheb
reviewed
Sep 20, 2021
tribuo-classification/README.md
Outdated
| screen. | ||
| This sample can be extended further to tweak the model parameters, based off the evaluation result. The clients can send | ||
| more training data to better train the model. | ||
| The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign. |
Contributor
There was a problem hiding this comment.
Is this actually possible with the current version of the sample? I thought you could only use it for training and evaluating a model.
Haven't looked at this in a while so apologies if I'm mistaken
Contributor
Author
There was a problem hiding this comment.
Nope this says that - "This sample can be extended further to...".
Contributor
There was a problem hiding this comment.
Oh right, I read this as "This sample can be extended further to tweak the model parameters, based off the evaluation result." ... and then the following sentences you can already do. Maybe it would be clearer to phrase it like
This sample can be extended in a number of ways:
- ...
- ...
rusheb
reviewed
Sep 20, 2021
Comment on lines
+62
to
+63
| This sample can be extended in a number of ways: | ||
| * The clients can tweak the model parameters, based off the evaluation result. The clients can then send |
Contributor
There was a problem hiding this comment.
Suggested change
| This sample can be extended in a number of ways: | |
| * The clients can tweak the model parameters, based off the evaluation result. The clients can then send | |
| This sample can be extended in a number of ways: | |
| * Enable the clients to tweak the model parameters, based off the evaluation result. The clients could then send |
| * The clients can tweak the model parameters, based off the evaluation result. The clients can then send | ||
| more training data to better train the model. | ||
| The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign. | ||
| * The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign. |
Contributor
There was a problem hiding this comment.
Suggested change
| * The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign. | |
| * Enable the clients to send some input data once the model has been trained, to predict whether a tumor is malignant or benign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.