Skip to content

Conversation

@zabirauf
Copy link

Hey Tim,
Thanks for creating this. I like the way how you structured the Survey logic and made it easy to extend. I’m playing with React Native and wanted to consume the survey logic in it. Currently the repo is structured with both the web and survey part together. I was thinking of separating it out into two packages so that Survey can be published as NPM package independently.

I made the change to leverage Lerna for that. The PR is just a draft and still needs work to be able to merge. But I wanted to discuss this with you before making anymore changes to it. Let me know what you think or if you have an alternative approach in mind?

  • Make travis work
  • Update and move README
  • Create README for Survey package
  • Prettify according to the repo rules. (While changing it applied my local prettier settings)
  • Remove .DS_Store files

*I might be missing something here :)

@RISCfuture
Copy link
Owner

It would definitely help to separate all the Survey package stuff into a separate commit so I can review it easier. The difference in our linter settings is making it hard to see the actual changes.

@zabirauf zabirauf force-pushed the zabirauf/publish-survey branch from 9ca4f62 to 1d157c8 Compare June 5, 2020 06:13
@zabirauf
Copy link
Author

zabirauf commented Jun 5, 2020

@RISCfuture Updated the branch without my custom linting. Now you should be able to see the real diff.

"cldr-data": "^36.0.0",
"cldrjs": "^0.5.1",
"core-js": "^3.6.5",
"i-just-crashed-my-plane-survey": "^0.1.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why its not diffing correctly but the difference here is the new dependency on survey package

@RISCfuture
Copy link
Owner

Thanks. I will need to check out the project and make sure it still deploys properly to the gh-pages branch for hosting, and tests still pass. Looks like the travis config also needs to be updated to run the separate test suites.

Finally, we'll need a better NPM package name than i-crashed-my-plane-survey. Maybe something like survey-tree (which doesn't seem to be taken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants