Skip to content

Conversation

@ivarusic-amd
Copy link

Description

Adding missing operator GridSample, since it's supported in mgx.

@TedThemistokleous
Copy link
Collaborator

If you're using a migraphx version prior to the API change this would make sense, if not then this would be needed. Did issue resolve when this was added?

@ivarusic-amd
Copy link
Author

Yes, It resolved reported unsupported node in model-bench! Not sure about API change, i think we use mgx-driver 2.16.0 version and onnx 1.24.0, but i'll double check.

@TedThemistokleous
Copy link
Collaborator

Yes, It resolved reported unsupported node in model-bench! Not sure about API change, i think we use mgx-driver 2.16.0 version and onnx 1.24.0, but i'll double check.

We can add it in if for some reason you haven't picked up the MIGraphX API change - #197

If possible on your Onnxruntime branch that model bench is using you'll need this change.

@ivarusic-amd
Copy link
Author

You are right, i think we do not have that on wml-main branch. i'll create PR just for our branch then.

@TedThemistokleous
Copy link
Collaborator

TedThemistokleous commented Jan 19, 2026

Closing this as not needed for ROCm 7.2

@ivarusic-amd @apwojcik ensure you get this also into wml-main - #197 & #198

This allows you to Querry the latest MIGraphX API to determine operator support. Should save you PR's and work from unsupported Ops. If you do run into a missing operator and parser support just needs to be added to MIGraphX instead of doing an update to this list in MIGraphX EP. Most times we can just reuse existing MIGX Ops for parsers or improve upon an existing design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants