Install MITuna's python modules from requirements on develop #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorde-antic
requested review from
dhernandez0,
djramic,
justinrosner,
mirza-halilcevic,
stefankoncarevic and
umangyadav
Contributor
|
why not merge requirements.txt from merge-from-develop to pf-tuna-rocmlir-3? Then, we only need one PR? |
Contributor
Author
I wasn't sure if it would trigger docker to be rebuilt @dhernandez0 |
Contributor
I think there's a Jenkins thing to manually trigger a rebuild of docker, @stefankoncarevic might know how to do it |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For making sure changes tested here work, we need docker to be rebuilt with modules from MITuna's requirements on develop installed.
This PR should be merged temporarily and later removed since we would have all those modules in requirements on our MITuna branch.