Fix element type mismatch in attention preSoftmax fusion #2211
+125
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a crash that MIGraphX was seeing when compiling an attention kernel with fusion: https://amd-hub.atlassian.net/browse/AIROCMLIR-438
Technical Details
When lowering
gridwise_attention_accelops with preSoftmax fusion, the gemm0 output buffer element type was unconditionally set toelemTypeV(the values input element type). This caused a type mismatch when the preSoftmax body'slinalg.genericexpected a different element type for it's gemm0 based input (e.g., when thelinalg.genericwas truncating/extending).Test Plan
Test Result
Submission Checklist