602 update clone from s3 to warn about missing gages#603
Merged
Conversation
Contributor
samland1116
commented
Dec 11, 2025
samland1116
commented
- adds message when subsetting locations table if a gage specified in the user's subset list is absent from the template
- adds message when subsetting primary_timeseries table if a gage specified in the user's subset list has no observations
…_s3-to-warn-about-missing-gages
samlamont
reviewed
Jan 6, 2026
| sdf_in = sdf_in.filter( | ||
| sdf_in.location_id.isin(primary_location_ids) | ||
| ) | ||
| # warn user if no timeseries data exists for a gage |
Collaborator
There was a problem hiding this comment.
Kind of a nitpick but it seems like this check is redundant to the first check in the locations table? I think our validation ensures that a location id in the primary table has to be in the locations table.
samlamont
approved these changes
Jan 7, 2026
samlamont
deleted the
602-update-clone_from_s3-to-warn-about-missing-gages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.