feat: Score monitors for Score Based Ambiguity solver

.github/workflows/analysis.yml

@@ -82,7 +82,7 @@ jobs:
 
       - name: Save PR number to file
         if: github.event_name == 'pull_request'
-        run: echo ${{ github.event.number }} > PR_NUMBER.txt
+        run: echo -n ${{ github.event.number }} > PR_NUMBER.txt
 
       - name: Persist PR number
         if: github.event_name == 'pull_request'

.github/workflows/builds.yml

@@ -158,7 +158,7 @@ jobs:
           source build/this_acts_withdeps.sh
           python3 -m pip install -r Examples/Python/tests/requirements.txt
           python3 -m pip install pytest-md-report
-          pytest -rfExw -k "not exatrkx" -v
+          pytest -rfExw -k "not gnn" -v
           cat ${PYTEST_MD_REPORT_OUTPUT} >> $GITHUB_STEP_SUMMARY
 
   linux_physmon:

.github/workflows/sonarcloud.yml

@@ -113,30 +113,30 @@ jobs:
           ls -al build/coverage
 
       - name: Run sonar-scanner (PR mode)
-        uses: SonarSource/sonarqube-scan-action@v5.3.0
+        uses: SonarSource/sonarqube-scan-action@v5.3.1
         if: github.event.workflow_run.event == 'pull_request'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
         with:
           args: >
-            --define sonar.cfamily.compile-commands="build/compile_commands.json"
+            --define sonar.cfamily.compile-commands=build/compile_commands.json
             --define sonar.coverageReportPaths=build/coverage/cov.xml
-            --define sonar.projectVersion="${{ steps.next_version.outputs.content }}"
-            --define sonar.scm.revision="${{ github.event.workflow_run.head_sha }}"
-            --define sonar.pullrequest.key="${{ steps.pr_number.outputs.content }}"
-            --define sonar.pullrequest.branch="${{ fromJson(steps.get_pr_data.outputs.data).head.ref }}"
-            --define sonar.pullrequest.base="${{ fromJson(steps.get_pr_data.outputs.data).base.ref }}"
+            --define sonar.projectVersion=${{ steps.next_version.outputs.content }}
+            --define sonar.scm.revision=${{ github.event.workflow_run.head_sha }}
+            --define sonar.pullrequest.key=${{ steps.pr_number.outputs.content }}
+            --define sonar.pullrequest.branch=${{ fromJson(steps.get_pr_data.outputs.data).head.ref }}
+            --define sonar.pullrequest.base=${{ fromJson(steps.get_pr_data.outputs.data).base.ref }}
 
       - name: Run sonar-scanner (push mode)
-        uses: SonarSource/sonarqube-scan-action@v5.3.0
+        uses: SonarSource/sonarqube-scan-action@v5.3.1
         if: github.event.workflow_run.event == 'push' && github.ref == 'refs/heads/main'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
         with:
           args: >
-            --define sonar.cfamily.compile-commands="build/compile_commands.json"
+            --define sonar.cfamily.compile-commands=build/compile_commands.json
             --define sonar.coverageReportPaths=build/coverage/cov.xml
-            --define sonar.projectVersion="${{ steps.next_version.outputs.content }}"
+            --define sonar.projectVersion=${{ steps.next_version.outputs.content }}
             --define sonar.branch.name=main

.gitlab-ci.yml

@@ -100,7 +100,7 @@ clang_tidy:
   after_script:
    - !reference [.spack_cleanup, after_script]
 
-build_exatrkx_cpu:
+build_gnn_cpu:
   stage: build
   image: registry.cern.ch/ghcr.io/acts-project/ubuntu2404_exatrkx:80
   tags:
@@ -126,9 +126,9 @@ build_exatrkx_cpu:
     # Here we only do a minimal build without examples to save resources
     - >
       cmake -B build -S src
-      --preset=gitlab-ci-exatrkx
-      -DACTS_EXATRKX_ENABLE_CUDA=OFF
-      -DACTS_EXATRKX_ENABLE_MODULEMAP=OFF
+      --preset=gitlab-ci-gnn
+      -DACTS_GNN_ENABLE_CUDA=OFF
+      -DACTS_GNN_ENABLE_MODULEMAP=OFF
 
     - ccache -z
     - cmake --build build -- -j6
@@ -137,7 +137,7 @@ build_exatrkx_cpu:
   after_script:
    - !reference [.spack_cleanup, after_script]
 
-build_exatrkx:
+build_gnn:
   stage: build
   image: registry.cern.ch/ghcr.io/acts-project/ubuntu2404_exatrkx:80
   tags:
@@ -170,7 +170,7 @@ build_exatrkx:
     - mkdir build
     - >
       cmake -B build -S src
-      --preset=gitlab-ci-exatrkx
+      --preset=gitlab-ci-gnn
 
     - ccache -z
     - cmake --build build -- -j6
@@ -179,10 +179,10 @@ build_exatrkx:
   after_script:
    - !reference [.spack_cleanup, after_script]
 
-test_exatrkx_unittests:
+test_gnn_unittests:
   stage: test
   needs:
-    - build_exatrkx
+    - build_gnn
   image: registry.cern.ch/ghcr.io/acts-project/ubuntu2404_exatrkx:80
   tags:
     - docker-gpu-nvidia
@@ -199,15 +199,15 @@ test_exatrkx_unittests:
       CI/dependencies/setup.sh -c g++ -e .env
       source .env
     - cd ..
-    - ctest --test-dir build -R "(ExaTrkX|ConnectedComponentsCuda|JunctionRemoval|Tensor)"
+    - ctest --test-dir build -R "(Gnn|ConnectedComponentsCuda|JunctionRemoval|Tensor)"
 
   after_script:
    - !reference [.spack_cleanup, after_script]
 
-test_exatrkx_python:
+test_gnn_python:
   stage: test
   needs:
-    - build_exatrkx
+    - build_gnn
   image: registry.cern.ch/ghcr.io/acts-project/ubuntu2404_exatrkx:80
   tags:
     - docker-gpu-nvidia
@@ -356,7 +356,7 @@ linux_test_examples:
     - source build/this_acts_withdeps.sh
     - cd src
     - python3 -m pip install -r Examples/Python/tests/requirements.txt
-    - pytest -rfExw -k "not exatrkx" -v
+    - pytest -rfExw -k "not gnn" -v
 
   after_script:
    - !reference [.spack_cleanup, after_script]

CI/physmon/workflows/physmon_trackfitting_kf.py

@@ -24,6 +24,8 @@
         field=setup.field,
         digiConfigFile=setup.digiConfig,
         outputDir=tp,
+        reverseFilteringMomThreshold=float("inf"),
+        reverseFilteringCovarianceScaling=100.0,
         s=s,
     )
 

CI/physmon/workflows/physmon_trackrefitting_kf.py

@@ -24,6 +24,8 @@
         field=setup.field,
         digiConfigFile=setup.digiConfig,
         outputDir=tp,
+        reverseFilteringMomThreshold=float("inf"),
+        reverseFilteringCovarianceScaling=100.0,
         s=s,
     )
 

CMakeLists.txt

@@ -85,12 +85,12 @@ option(ACTS_BUILD_PLUGIN_FASTJET "Build FastJet plugin" OFF)
 option(ACTS_BUILD_PLUGIN_GEOMODEL "Build GeoModel plugin" OFF)
 option(ACTS_BUILD_PLUGIN_TRACCC "Build Traccc plugin" OFF)
 option(ACTS_BUILD_PLUGIN_GEANT4 "Build Geant4 plugin" OFF)
-option(ACTS_BUILD_PLUGIN_EXATRKX "Build the Exa.TrkX plugin" OFF)
-option(ACTS_EXATRKX_ENABLE_ONNX "Build the Onnx backend for the exatrkx plugin" OFF)
-option(ACTS_EXATRKX_ENABLE_TORCH "Build the torchscript backend for the exatrkx plugin" ON)
-option(ACTS_EXATRKX_ENABLE_CUDA "Enable CUDA for the exatrkx plugin" OFF)
-option(ACTS_EXATRKX_ENABLE_MODULEMAP "Enable Module-Map-based graph construction" OFF)
-option(ACTS_EXATRKX_ENABLE_TENSORRT "Enable the native TensorRT inference modules" OFF)
+option(ACTS_BUILD_PLUGIN_GNN "Build the GNN plugin" OFF)
+option(ACTS_GNN_ENABLE_ONNX "Build the Onnx backend for the gnn plugin" OFF)
+option(ACTS_GNN_ENABLE_TORCH "Build the torchscript backend for the gnn plugin" ON)
+option(ACTS_GNN_ENABLE_CUDA "Enable CUDA for the gnn plugin" OFF)
+option(ACTS_GNN_ENABLE_MODULEMAP "Enable Module-Map-based graph construction" OFF)
+option(ACTS_GNN_ENABLE_TENSORRT "Enable the native TensorRT inference modules" OFF)
 option(ACTS_BUILD_PLUGIN_JSON "Build json plugin" OFF)
 option(ACTS_BUILD_PLUGIN_ONNX "Build ONNX plugin" OFF)
 option(ACTS_BUILD_PLUGIN_ROOT "Build ROOT plugin" OFF)
@@ -105,7 +105,7 @@ option(ACTS_BUILD_ALIGNMENT "Build Alignment package" OFF)
 option(ACTS_BUILD_EXAMPLES_DD4HEP "Build DD4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_EDM4HEP "Build EDM4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_PODIO "Build Podio-based code in the examples" OFF)
-option(ACTS_BUILD_EXAMPLES_EXATRKX "Build the Exa.TrkX example code" OFF)
+option(ACTS_BUILD_EXAMPLES_GNN "Build the GNN example code" OFF)
 option(ACTS_BUILD_EXAMPLES_GEANT4 "Build Geant4-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_HASHING "Build Hashing-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_PYTHIA8 "Build Pythia8-based code in the examples" OFF)
@@ -155,7 +155,7 @@ set_option_if(
     OR
     ACTS_BUILD_EXAMPLES_PYTHIA8
     OR
-    ACTS_BUILD_EXAMPLES_EXATRKX
+    ACTS_BUILD_EXAMPLES_GNN
     OR
     ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS
 )
@@ -187,12 +187,12 @@ set_option_if(
 )
 set_option_if(ACTS_BUILD_PLUGIN_JSON ACTS_BUILD_EXAMPLES)
 set_option_if(ACTS_BUILD_FATRAS ACTS_BUILD_EXAMPLES)
-set_option_if(ACTS_BUILD_PLUGIN_EXATRKX ACTS_BUILD_EXAMPLES_EXATRKX)
+set_option_if(ACTS_BUILD_PLUGIN_GNN ACTS_BUILD_EXAMPLES_GNN)
 set_option_if(ACTS_BUILD_PLUGIN_FPEMON ACTS_BUILD_EXAMPLES)
 set_option_if(ACTS_BUILD_PLUGIN_JSON ACTS_BUILD_PLUGIN_TRACCC)
 set_option_if(ACTS_BUILD_PLUGIN_ACTSVG ACTS_BUILD_PLUGIN_TRACCC)
 set_option_if(ACTS_BUILD_PLUGIN_HASHING ACTS_BUILD_EXAMPLES_HASHING)
-set_option_if(ACTS_EXATRKX_ENABLE_CUDA ACTS_EXATRKX_ENABLE_MODULEMAP)
+set_option_if(ACTS_GNN_ENABLE_CUDA ACTS_GNN_ENABLE_MODULEMAP)
 
 # feature tests
 include(CheckCXXSourceCompiles)
@@ -417,27 +417,27 @@ if(ACTS_BUILD_ANALYSIS_APPS)
     )
     check_root_compatibility()
 endif()
-if(ACTS_BUILD_PLUGIN_EXATRKX)
-    if(ACTS_EXATRKX_ENABLE_CUDA)
+if(ACTS_BUILD_PLUGIN_GNN)
+    if(ACTS_GNN_ENABLE_CUDA)
         find_package(CUDAToolkit REQUIRED)
         enable_cuda()
-        message(STATUS "Build Exa.TrkX plugin with CUDA")
+        message(STATUS "Build GNN plugin with CUDA")
     else()
-        message(STATUS "Build Exa.TrkX plugin for CPU only")
+        message(STATUS "Build GNN plugin for CPU only")
     endif()
-    if(ACTS_EXATRKX_ENABLE_TORCH)
+    if(ACTS_GNN_ENABLE_TORCH)
         find_package(Torch REQUIRED)
         add_subdirectory(thirdparty/FRNN)
     endif()
-    if(ACTS_EXATRKX_ENABLE_MODULEMAP)
+    if(ACTS_GNN_ENABLE_MODULEMAP)
         if(ACTS_USE_SYSTEM_MODULEMAPGRAPH)
             find_package(ModuleMapGraph REQUIRED COMPONENTS CPU GPU)
         else()
             add_subdirectory(thirdparty/ModuleMapGraph)
         endif()
     endif()
 endif()
-if(ACTS_BUILD_PLUGIN_ONNX OR ACTS_EXATRKX_ENABLE_ONNX)
+if(ACTS_BUILD_PLUGIN_ONNX OR ACTS_GNN_ENABLE_ONNX)
     find_package(onnxruntime ${_acts_onnxruntime_version} MODULE REQUIRED)
 endif()
 if(ACTS_BUILD_PLUGIN_EDM4HEP OR ACTS_BUILD_PLUGIN_PODIO)

CMakePresets.json

@@ -62,14 +62,14 @@
                 "ACTS_BUILD_PLUGIN_GEOMODEL": "ON",
                 "ACTS_BUILD_PLUGIN_TRACCC": "ON",
                 "ACTS_BUILD_PLUGIN_GEANT4": "ON",
-                "ACTS_BUILD_PLUGIN_EXATRKX": "OFF",
+                "ACTS_BUILD_PLUGIN_GNN": "OFF",
                 "ACTS_BUILD_PLUGIN_JSON": "ON",
                 "ACTS_BUILD_PLUGIN_ONNX": "OFF",
                 "ACTS_BUILD_PLUGIN_TGEO": "ON",
                 "ACTS_BUILD_PLUGIN_FASTJET": "ON",
                 "ACTS_BUILD_EXAMPLES_EDM4HEP": "ON",
                 "ACTS_BUILD_EXAMPLES_PODIO": "ON",
-                "ACTS_BUILD_EXAMPLES_EXATRKX": "OFF",
+                "ACTS_BUILD_EXAMPLES_GNN": "OFF",
                 "ACTS_BUILD_EXAMPLES_GEANT4": "ON",
                 "ACTS_BUILD_EXAMPLES_PYTHIA8": "ON",
                 "ACTS_BUILD_EXAMPLES_HASHING": "ON",
@@ -120,8 +120,8 @@
             }
         },
         {
-            "name": "gitlab-ci-exatrkx",
-            "displayName": "GitLab-CI ExaTrkX",
+            "name": "gitlab-ci-gnn",
+            "displayName": "GitLab-CI Gnn",
             "generator": "Ninja",
             "cacheVariables": {
                 "CMAKE_CXX_STANDARD": "20",
@@ -133,14 +133,14 @@
                 "CMAKE_CUDA_ARCHITECTURES": "86",
                 "TORCH_CUDA_ARCH_LIST": "8.6",
                 "ACTS_FORCE_ASSERTIONS": "ON",
-                "ACTS_BUILD_PLUGIN_EXATRKX": "ON",
+                "ACTS_BUILD_PLUGIN_GNN": "ON",
                 "ACTS_BUILD_EXAMPLES_ROOT": "ON",
-                "ACTS_BUILD_EXAMPLES_EXATRKX": "ON",
+                "ACTS_BUILD_EXAMPLES_GNN": "ON",
                 "ACTS_BUILD_UNITTESTS": "ON",
-                "ACTS_EXATRKX_ENABLE_TORCH": "ON",
-                "ACTS_EXATRKX_ENABLE_ONNX": "ON",
-                "ACTS_EXATRKX_ENABLE_CUDA": "ON",
-                "ACTS_EXATRKX_ENABLE_MODULEMAP": "ON",
+                "ACTS_GNN_ENABLE_TORCH": "ON",
+                "ACTS_GNN_ENABLE_ONNX": "ON",
+                "ACTS_GNN_ENABLE_CUDA": "ON",
+                "ACTS_GNN_ENABLE_MODULEMAP": "ON",
                 "ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS": "ON",
                 "ACTS_ENABLE_LOG_FAILURE_THRESHOLD": "ON"
             }
@@ -154,11 +154,11 @@
                 "CMAKE_CXX_COMPILER_LAUNCHER": "ccache",
                 "CMAKE_CUDA_ARCHITECTURES": "86",
                 "TORCH_CUDA_ARCH_LIST": "8.6",
-                "ACTS_BUILD_PLUGIN_EXATRKX": "ON",
-                "ACTS_EXATRKX_ENABLE_TORCH": "OFF",
-                "ACTS_EXATRKX_ENABLE_CUDA": "ON",
-                "ACTS_EXATRKX_ENABLE_TENSORRT": "ON",
-                "ACTS_EXATRKX_ENABLE_MODULEMAP": "OFF"
+                "ACTS_BUILD_PLUGIN_GNN": "ON",
+                "ACTS_GNN_ENABLE_TORCH": "OFF",
+                "ACTS_GNN_ENABLE_CUDA": "ON",
+                "ACTS_GNN_ENABLE_TENSORRT": "ON",
+                "ACTS_GNN_ENABLE_MODULEMAP": "OFF"
             }
         }
     ]

CODE_OF_CONDUCT.md

@@ -1,6 +1,6 @@
 # Code Of Conduct
 
-The Acts project observes [CERN's Code of Conduct](https://cern.ch/codeofconduct).
+The ACTS project observes [CERN's Code of Conduct](https://cern.ch/codeofconduct).
 Below is a plain text summary of the [official PDF](https://cds.cern.ch/record/2240689/files/BrochureCodeofConductEN.pdf?)
 as of 1. April 2020. Please consult the [PDF](https://cds.cern.ch/record/2240689/files/BrochureCodeofConductEN.pdf?)
 for up-to-date information.