RFC: Drop tokenizer::Token intermediate data structure and XmlEvent trait#139
Open
adamreichold wants to merge 1 commit intomasterfrom
Open
RFC: Drop tokenizer::Token intermediate data structure and XmlEvent trait#139adamreichold wants to merge 1 commit intomasterfrom
adamreichold wants to merge 1 commit intomasterfrom
Conversation
adamreichold
force-pushed
the
no-token-no-cry
branch
from
a3c3195 to
f73b5a7
Compare
This simplifies the code base, especially the interaction between tokenizer and parser. However, it also appears to imply that we have to drop the tokenizer test which intimately rely on the intermediate token representation. Further code clean-ups are possible, e.g. standardizing on methods on Context instead of free functions, but this change aims for a minimal change while we discuss this.
adamreichold
force-pushed
the
no-token-no-cry
branch
from
f73b5a7 to
16bb813
Compare
Owner
|
Looks good, but we must keep the tests. Removing them is not an option. Not sure what we can do about it. |
Collaborator
Author
The only thing that comes to my mind is conditional compilation, i.e. have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed previously here, this simplifies the code base, especially the interaction between tokenizer and parser. However, it also appears to imply that we have to drop the tokenizer test which intimately rely on the intermediate token representation.
Further code clean-ups are possible, e.g. standardizing on methods on Context instead of free functions, but this change aims for a minimal change while we discuss this.