Skip to content

Conversation

@TysonStanley
Copy link
Member

Now that 1.18.0 is on CRAN, we are bumping master to 1.18.99.

@TysonStanley TysonStanley requested review from a team and MichaelChirico as code owners December 24, 2025 23:20
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Be sure to add the tag for 1.18.0 as well

@MichaelChirico MichaelChirico merged commit a29c209 into master Dec 24, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the cran-1.18.0 branch December 24, 2025 23:24
@TysonStanley
Copy link
Member Author

Thanks, I did tag it but it isn't showing up on GitHub. Investigating why, will redo if necessary.

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.97%. Comparing base (e455714) to head (8073130).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/init.c 83.78% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7513      +/-   ##
==========================================
- Coverage   99.04%   98.97%   -0.07%     
==========================================
  Files          87       87              
  Lines       16707    16740      +33     
==========================================
+ Hits        16547    16568      +21     
- Misses        160      172      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

  • HEAD=cran-1.18.0 stopped early for DT[by,verbose=TRUE] improved in #6296
  • HEAD=cran-1.18.0 stopped early for DT[,.SD] improved in #4501
    Comparison Plot

Generated via commit 8073130

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 17 seconds
Installing different package versions 11 minutes and 42 seconds
Running and plotting the test cases 4 minutes and 21 seconds

Copy link
Member

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.18.0 tag is visible now.

Comment on lines 154 to 155

#: assign.c:326
#, c-format
msgid "Added %d new column initialized with all-NA\n"
msgstr ""

#: assign.c:332
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be missing the singular forms of the translated messages from the Pl_ macro. @MichaelChirico, what's the right xgettext call to capture them?

{NULL, NULL, 0}
};
static const R_CallMethodDef callMethods[] = {
{"Csetattrib", (DL_FUNC)&setattrib, -1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you apply a C source formatter or perform the changes manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants