Skip to content

[FIX] 제안을 받으면 즉시 발송으로 임시 변경 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1000hyehyang merged 2 commits into from
Feb 9, 2026
Merged

[FIX] 제안을 받으면 즉시 발송으로 임시 변경 #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffc46b
fix(#343): 제안을 받으면 즉시 발송으로 임시 변경
1000hyehyang Feb 9, 2026
82beebd
fix(#343): 코드리뷰 반영
1000hyehyang Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions ...a/com/example/RealMatch/notification/application/service/NotificationChannelResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,20 @@
/**
* NotificationKind별 즉시 발송 채널을 결정한다.
*
* PRD §5.2 기준:
* - PROPOSAL_RECEIVED : PUSH만 (이메일은 1일 후 스케줄러에서 별도 처리)
* - PROPOSAL_SENT : PUSH만
* - CAMPAIGN_APPLIED : PUSH만
* - CAMPAIGN_MATCHED : PUSH + EMAIL (매칭 직후 즉시 이메일)
* - CAMPAIGN_COMPLETED: PUSH + EMAIL (데모데이 이후)
* - SETTLEMENT_READY : PUSH만
* - AUTO_CONFIRMED : EMAIL만 (데모데이 이후)
* - CHAT_MESSAGE : PUSH만
* <p>PRD §5.2 기준:
* <ul>
* <li>PROPOSAL_RECEIVED : PUSH + EMAIL (현재는 즉시 발송. 데모데이 이후에는 이메일만 1일 후 스케줄러로 변경 예정)</li>
* <li>PROPOSAL_SENT : PUSH만</li>
* <li>CAMPAIGN_APPLIED : PUSH만</li>
* <li>CAMPAIGN_MATCHED : PUSH + EMAIL (매칭 직후 즉시 이메일)</li>
* <li>CAMPAIGN_COMPLETED: PUSH + EMAIL (데모데이 이후)</li>
* <li>SETTLEMENT_READY : PUSH만</li>
* <li>AUTO_CONFIRMED : EMAIL만 (데모데이 이후)</li>
* <li>CHAT_MESSAGE : PUSH만</li>
* </ul>
*
* TODO(데모데이 이후): PROPOSAL_RECEIVED 이메일은 즉시 발송 대신, 1일 경과 + 미읽음(isRead=false)인 건만
* 스케줄러에서 조회 후 이메일 발송하도록 변경. (PRD §5.2 이메일 ①)
*/
@Component
public class NotificationChannelResolver {
Expand All @@ -32,8 +37,9 @@ public class NotificationChannelResolver {
static {
Map<NotificationKind, Set<NotificationChannel>> map = new EnumMap<>(NotificationKind.class);

// 현재: 제안 수신 시 푸시 + 이메일 즉시 발송. 데모데이 이후 이메일은 1일 후 스케줄러로 전환 예정(TODO)
map.put(NotificationKind.PROPOSAL_RECEIVED,
EnumSet.of(NotificationChannel.PUSH));
EnumSet.of(NotificationChannel.PUSH, NotificationChannel.EMAIL));
map.put(NotificationKind.PROPOSAL_SENT,
EnumSet.of(NotificationChannel.PUSH));
map.put(NotificationKind.CAMPAIGN_APPLIED,
Expand Down
6 changes: 3 additions & 3 deletions ...m/example/RealMatch/notification/application/service/NotificationChannelResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ class NotificationChannelResolverTest {
private final NotificationChannelResolver resolver = new NotificationChannelResolver();

@Test
@DisplayName("PROPOSAL_RECEIVED는 PUSH만 반환")
void resolveChannels_shouldReturnPushOnly_whenProposalReceived() {
@DisplayName("PROPOSAL_RECEIVED는 PUSH와 EMAIL을 반환")
void resolveChannels_shouldReturnPushAndEmail_whenProposalReceived() {
// when
Set<NotificationChannel> channels = resolver.resolveChannels(NotificationKind.PROPOSAL_RECEIVED);

// then
assertThat(channels).containsExactly(NotificationChannel.PUSH);
assertThat(channels).containsExactlyInAnyOrder(NotificationChannel.PUSH, NotificationChannel.EMAIL);
}

@Test
Expand Down
Loading