Skip to content

[FIX] 이미지 url 사이즈 제거 (#358) #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lingard1234 merged 2 commits into from
Feb 10, 2026
Merged

[FIX] 이미지 url 사이즈 제거 (#358) #359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7d4fc
fix(#358): url size제거
lingard1234 Feb 10, 2026
69e64be
Merge branch 'dev' into fix/358-profileurl
lingard1234 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...va/com/example/RealMatch/user/presentation/dto/request/MyProfileCardUpdateRequestDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.example.RealMatch.user.presentation.dto.request;

import jakarta.validation.constraints.Size;
import lombok.Getter;
import lombok.NoArgsConstructor;

Expand All @@ -9,6 +8,5 @@
public class MyProfileCardUpdateRequestDto {

@jakarta.validation.constraints.NotBlank
@Size(max = 255)
private String profileImageUrl;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The @Size(max = 255) validation on the profileImageUrl field has been removed. While the goal was to accommodate longer URLs, removing the length validation entirely creates several risks. An excessively long string could lead to DataTruncationException if the corresponding database column has a size limit, potentially causing 500 errors and a Denial of Service. Furthermore, a malicious user could submit an extremely long string to exploit this. There is also no validation to ensure the provided string is a valid URL, which could lead to stored Cross-Site Scripting (XSS) if the profileImageUrl is rendered without proper sanitization on the client-side. To mitigate these issues, it's crucial to reintroduce a more generous length limit (e.g., @Size(max = 2048)) and add URL format validation (@URL).

    @jakarta.validation.constraints.NotBlank
    @org.hibernate.validator.constraints.URL
    @jakarta.validation.constraints.Size(max = 2048)
    private String profileImageUrl;

}
Loading