Skip to content

Comments

[FIX] snsurl 형식수정 (#383)#384

Merged
lingard1234 merged 2 commits intodevfrom
fix/383-editsns
Feb 11, 2026
Merged

[FIX] snsurl 형식수정 (#383)#384
lingard1234 merged 2 commits intodevfrom
fix/383-editsns

Conversation

@lingard1234
Copy link
Contributor

Summary

Changes

Type of Change

  • Bug fix (기존 기능에 영향을 주지 않는 버그 수정)
  • New feature (기존 기능에 영향을 주지 않는 새로운 기능 추가)
  • Breaking change (기존 기능에 영향을 주는 수정)
  • Refactoring (기능 변경 없는 코드 개선)
  • Documentation (문서 수정)
  • Chore (빌드, 설정 등 기타 변경)
  • Release (develop → main 배포)

Related Issues

참고 사항

@lingard1234 lingard1234 self-assigned this Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lingard1234, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 SNS URL 처리 로직의 견고성을 향상시키는 것을 목표로 합니다. 특히 Instagram URL에서 사용자 계정 이름을 추출하는 과정에서 발생할 수 있는 다양한 형식의 URL을 올바르게 처리할 수 있도록 개선하여, 사용자 프로필 카드에 정확한 정보를 표시할 수 있도록 합니다.

Highlights

  • SNS URL 형식 수정: MyProfileCardResponseDto.java 파일에서 Instagram SNS URL에서 계정 이름을 추출하는 로직을 개선했습니다. 기존 replace 메서드 대신 정규 표현식을 사용하는 replaceAll 메서드를 도입하여 https://www.instagram.com/instagram.com 접두사를 더 유연하게 처리하고, 슬래시(/) 문자를 제거하며, 최종적으로 문자열의 양 끝 공백을 제거하도록 변경했습니다.
Changelog
  • src/main/java/com/example/RealMatch/user/presentation/dto/response/MyProfileCardResponseDto.java
    • Instagram SNS URL에서 계정 이름을 추출하는 로직이 replace에서 replaceAll을 사용하는 방식으로 변경되었습니다.
    • URL 접두사(https://www.instagram.com/, instagram.com) 및 슬래시 제거 로직이 정규 표현식을 사용하여 더 유연하게 처리되도록 수정되었습니다.
    • 추출된 계정 이름의 양 끝 공백을 제거하는 trim() 메서드가 추가되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lingard1234 lingard1234 merged commit 28ffa89 into dev Feb 11, 2026
1 check passed
@lingard1234 lingard1234 deleted the fix/383-editsns branch February 11, 2026 13:58
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve the logic for extracting Instagram account usernames from snsUrl using regular expressions. However, the use of regular expressions for URL parsing is generally discouraged in this repository as it can lead to overly complex and potentially vulnerable implementations, especially when input formats are not strictly guaranteed. As per repository guidelines, simpler string manipulation should be used if the input format is guaranteed, or a dedicated URL parsing library for robust handling of untrusted URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant