Skip to content

fix(#385): 캠페인 제안에 캠페인 id 추가 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ParkJiYeoung8297 merged 1 commit into from
Feb 11, 2026
Merged

fix(#385): 캠페인 제안에 캠페인 id 추가 #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../example/RealMatch/business/presentation/dto/response/CampaignProposalDetailResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import java.time.LocalDateTime;

import com.example.RealMatch.business.domain.entity.CampaignProposal;
import com.example.RealMatch.campaign.domain.entity.Campaign;

import lombok.Builder;
import lombok.Getter;
Expand All @@ -13,6 +14,8 @@
public class CampaignProposalDetailResponse {

private Long proposalId;
private Long campaignId;
private String campaignName;

private Long brandId;
private Long creatorId;
Expand All @@ -34,8 +37,12 @@ public class CampaignProposalDetailResponse {
private CampaignContentTagResponse contentTags;

public static CampaignProposalDetailResponse from(CampaignProposal proposal) {
Campaign campaign = proposal.getCampaign();

return CampaignProposalDetailResponse.builder()
.proposalId(proposal.getId())
.campaignId(campaign != null ? campaign.getId() : null)
.campaignName(campaign != null ? campaign.getTitle() : null)
.brandId(proposal.getBrand().getId())
.creatorId(proposal.getCreator().getId())
.title(proposal.getTitle())
Expand Down
3 changes: 3 additions & 0 deletions ...ain/java/com/example/RealMatch/business/presentation/swagger/CampaignProposalSwagger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ CustomResponse<String> modifyCampaignProposal(
summary = "캠페인 제안 상세 조회 API by 박지영",
description = """
한 건의 캠페인 제안 상세 정보를 조회합니다.

* 기존 캠페인 제안일 경우 campaignId와 campaignName 값이 있습니다. 제목을 campaignName을 사용해주세요.
* 신규 캠페인 제안일 경우 campaignId와 campaignName 값이 null 입니다. 제목을 title을 사용해주세요.
Comment on lines +142 to +143
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

API 문서 설명에 불필요한 후행 공백이 포함되어 있습니다. 코드 스타일을 일관성 있게 유지하고 가독성을 높이기 위해 제거하는 것이 좋습니다.

Suggested change
* 기존 캠페인 제안일 경우 campaignId와 campaignName 값이 있습니다. 제목을 campaignName을 사용해주세요.
* 신규 캠페인 제안일 경우 campaignId와 campaignName 값이 null 입니다. 제목을 title을 사용해주세요.
* 기존 캠페인 제안일 경우 campaignId와 campaignName 값이 있습니다. 제목을 campaignName을 사용해주세요.
* 신규 캠페인 제안일 경우 campaignId와 campaignName 값이 null 입니다. 제목을 title을 사용해주세요.


campaignProposalId는 /api/v1/campaigns/collaborations/me에서 확인해주세요.
(masterJWT로 조회 불가능 API, 크리에이터/브랜드 계정으로 로그인 필요)
Expand Down
Loading