Skip to content

Comments

[FIX] 알림 이메일 경로 수정#390

Merged
1000hyehyang merged 1 commit intodevfrom
fix/389-notification
Feb 12, 2026
Merged

[FIX] 알림 이메일 경로 수정#390
1000hyehyang merged 1 commit intodevfrom
fix/389-notification

Conversation

@1000hyehyang
Copy link
Member

Summary

Changes

Type of Change

  • Bug fix (기존 기능에 영향을 주지 않는 버그 수정)
  • New feature (기존 기능에 영향을 주지 않는 새로운 기능 추가)
  • Breaking change (기존 기능에 영향을 주는 수정)
  • Refactoring (기능 변경 없는 코드 개선)
  • Documentation (문서 수정)
  • Chore (빌드, 설정 등 기타 변경)
  • Release (develop → main 배포)

Related Issues

참고 사항

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @1000hyehyang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 알림 이메일에 포함된 프론트엔드 알림 페이지 URL이 잘못 지정된 문제를 해결합니다. /notifications 경로를 /notification으로 업데이트하여, 사용자가 알림 이메일 내 링크를 클릭했을 때 올바른 페이지로 이동하도록 보장하여 알림 시스템의 기능과 사용자 경험을 개선합니다.

Highlights

  • 알림 이메일 경로 수정: 알림 이메일에 포함되는 프론트엔드 알림 페이지 URL이 /notifications에서 /notification으로 수정되었습니다.
Changelog
  • src/main/java/com/example/RealMatch/notification/infrastructure/sender/EmailNotificationSender.java
    • 알림 이메일 본문 생성 시 사용되는 프론트엔드 알림 페이지 URL을 /notifications에서 /notification으로 수정했습니다.
Activity
  • 현재까지 풀 리퀘스트에 대한 사용자 활동 (댓글, 리뷰 등)은 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR fixes a broken link issue by updating the URL path in notification emails from /notifications to /notification. A security audit confirmed that no vulnerabilities were introduced by this change, which is limited to a single line in EmailNotificationSender.java and does not pose risks like injection or data exposure. For improved maintainability, a suggestion was made to externalize hardcoded URL paths into a configuration file.

@1000hyehyang 1000hyehyang merged commit 0e9f9d9 into dev Feb 12, 2026
1 check passed
@1000hyehyang 1000hyehyang deleted the fix/389-notification branch February 12, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant