fix: 정상테스트 api를 springSecurity에서 permit#398
Conversation
Summary of ChangesHello @ParkJiYeoung8297, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly permits the /api/test endpoint in Spring Security for unauthenticated access. This aligns with the TestController's description and is acceptable for temporary test fixtures during early development, as per repository guidelines. It is important to ensure this temporary configuration is removed or properly secured before feature completion.
| "/api/login/success", | ||
| "/api/v1/ws/**", | ||
| "/v3/api-docs/**", "/swagger-ui/**", "/swagger-resources/**", | ||
| "/api/test", |
There was a problem hiding this comment.
The addition of /api/test to the PERMIT_ALL_URL_ARRAY correctly allows unauthenticated access to this test endpoint. As per repository rule regarding temporary test fixtures in src/main/java, this is acceptable during early development stages. Please ensure this endpoint and its corresponding security configuration are removed or properly secured before the feature is considered complete and deployed to production.
References
- Test fixtures can be temporarily used in the main source set (
src/main/java) to provide sample responses for top-down contract validation during early development stages. This code must be replaced with actual service logic before the feature is considered complete.
fix: 정상테스트 api를 springSecurity에서 permit
Summary
정상테스트 api를 springSecurity에서 permit
Changes
Type of Change
Related Issues
참고 사항
해당 api는 서버와 정상 통신여부를 확인하기 위한 api로 권한 검증이 없어야합니다.