Skip to content

Comments

fix: 정상테스트 api를 springSecurity에서 permit#398

Merged
ParkJiYeoung8297 merged 1 commit intodevfrom
fix/spring-security-fix
Feb 19, 2026
Merged

fix: 정상테스트 api를 springSecurity에서 permit#398
ParkJiYeoung8297 merged 1 commit intodevfrom
fix/spring-security-fix

Conversation

@ParkJiYeoung8297
Copy link
Contributor

@ParkJiYeoung8297 ParkJiYeoung8297 commented Feb 19, 2026

fix: 정상테스트 api를 springSecurity에서 permit

Summary

정상테스트 api를 springSecurity에서 permit

Changes

image

Type of Change

  • Bug fix (기존 기능에 영향을 주지 않는 버그 수정)
  • New feature (기존 기능에 영향을 주지 않는 새로운 기능 추가)
  • Breaking change (기존 기능에 영향을 주는 수정)
  • Refactoring (기능 변경 없는 코드 개선)
  • Documentation (문서 수정)
  • Chore (빌드, 설정 등 기타 변경)
  • Release (develop → main 배포)

Related Issues

참고 사항

해당 api는 서버와 정상 통신여부를 확인하기 위한 api로 권한 검증이 없어야합니다.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ParkJiYeoung8297, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 /api/test 엔드포인트를 Spring Security의 인증 절차에서 제외하여, 해당 API가 인증 없이 접근 가능하도록 변경합니다. 이는 시스템의 정상 작동 여부를 확인하는 테스트 목적의 API에 대한 접근성을 개선하고, 불필요한 인증 과정을 생략하여 효율성을 높이는 데 기여합니다.

Highlights

  • /api/test 엔드포인트 접근 허용: Spring Security 설정에서 /api/test 경로를 인증 없이 접근할 수 있도록 허용했습니다. 이는 정상 작동 여부를 확인하는 테스트 API에 대한 접근성을 높이기 위함입니다.
Changelog
  • src/main/java/com/example/RealMatch/global/config/SecurityConfig.java
    • 정상 테스트 API 경로를 Spring Security에서 인증 없이 접근 가능하도록 허용했습니다.
Activity
  • PR 생성 이후 아직 별다른 활동이 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly permits the /api/test endpoint in Spring Security for unauthenticated access. This aligns with the TestController's description and is acceptable for temporary test fixtures during early development, as per repository guidelines. It is important to ensure this temporary configuration is removed or properly secured before feature completion.

"/api/login/success",
"/api/v1/ws/**",
"/v3/api-docs/**", "/swagger-ui/**", "/swagger-resources/**",
"/api/test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of /api/test to the PERMIT_ALL_URL_ARRAY correctly allows unauthenticated access to this test endpoint. As per repository rule regarding temporary test fixtures in src/main/java, this is acceptable during early development stages. Please ensure this endpoint and its corresponding security configuration are removed or properly secured before the feature is considered complete and deployed to production.

References
  1. Test fixtures can be temporarily used in the main source set (src/main/java) to provide sample responses for top-down contract validation during early development stages. This code must be replaced with actual service logic before the feature is considered complete.

@ParkJiYeoung8297 ParkJiYeoung8297 merged commit 856f422 into dev Feb 19, 2026
1 check passed
@ParkJiYeoung8297 ParkJiYeoung8297 deleted the fix/spring-security-fix branch February 19, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant