-
Notifications
You must be signed in to change notification settings - Fork 76
test: add SSZ test vectors #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I need to do another round of self-review before marking this ready for review |
| pub inner: FixedBytes<SIGNATURE_SIZE>, | ||
| pub inner: LeanSigSignature, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right way to do it, but since FixedBytes is how Ream stores it internally and needs conversion to LeanSigSignature to do any operation anyway, so I'm thinking we could just remove this interim FixedBytes and use LeanSigSignature directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will LeanSigSignature encode to FixedBytes though is the question? I will read your code, but that would be the concern
…ead of fixed bytes
1d195d9 to
9e95a6d
Compare
What was wrong?
Implement leanEthereum/leanSpec#380
TreeHashderive fromSignedAttestationbecause it's not used and it's in turn requiringSignatureto implementTreeHashas well which requires custom logic but also not used.Signature::innerfromFixedBytes<SIGNATURE_SIZE>toLeanSigSignatureso that the finalSignaturescheme type is used directly without needingFixedBytesin-betweenpassthrough_conversion,simple_conversion,nested_conversion,custom_conversionto handle the json camelCase conversion to Ream types.To-Do