Skip to content

feat(storage): add deprecation warning to dv.wait() #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dalia-frank wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(storage): add deprecation warning to dv.wait() #2613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13c0cb1
Storage: add deprecation warning to dv.wait()
dalia-frank Dec 15, 2025
28713d8
update warning message
dalia-frank Dec 17, 2025
0a157c7
Merge branch 'main' into deprecate_dv_wait
dalia-frank Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added go1.25.4.linux-amd64.tar.gz
View file
Open in desktop
Binary file not shown.
Binary file added go1.25.4.linux-amd64.tar.gz.1
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions ocp_resources/datavolume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@ def wait_deleted(self, timeout=TIMEOUT_4MINUTES):
return self.pvc.wait_deleted(timeout=timeout)

def wait(self, timeout=TIMEOUT_10MINUTES, failure_timeout=TIMEOUT_2MINUTES, wait_for_exists_only=False, sleep=1):
warn(
message="DataVolume.wait() is deprecated and will be removed in "
"the next version. Use wait_for_dv_success() instead.",
category=DeprecationWarning,
stacklevel=2,
)
if wait_for_exists_only:
return super().wait(timeout=timeout, sleep=sleep)
else:
Expand Down