Break after the first equals result_value to avoid duplicates#29
Merged
gkorland merged 3 commits intogeneric_json_pathfrom Mar 14, 2022
Merged
Break after the first equals result_value to avoid duplicates#29gkorland merged 3 commits intogeneric_json_pathfrom
gkorland merged 3 commits intogeneric_json_pathfrom
Conversation
MeirShpilraien
approved these changes
Mar 14, 2022
oshadmi
reviewed
Mar 14, 2022
| for result_value in &ret { | ||
| if (*map_value).eq(*result_value) { | ||
| tmp.push(*rel_value); | ||
| break; |
There was a problem hiding this comment.
Can use a label to break from the outer loop to get to the next rel_value?
'outer: for map_value in map.values() {
for result_value in &ret {
if map_value.eq(*result_value) {
tmp.push(*rel_value);
break 'outer;
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref freestrings#93
freestrings#92
fix RedisJSON/RedisJSON#667