Open
Conversation
Contributor
|
@NueloSE fix the pipeline |
Contributor
|
@NueloSE please fix the pipeline |
Author
|
@Baskarayelu kindly check fixed the pipeline issue now and resolved conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements missing test coverage for the
lock_goalandunlock_goalfunctionality in the Savings Goals contract. It ensures that locking restricts withdrawals and that only the owner can perform these actions.Additionally, this PR fixes a critical bug in the
add_to_goalfunction where duplicate logic caused ambiguity, and resolves compilation errors inlib.rs(duplicate imports, moved values).Changes
src/test.rscovering:src/test.rs.add_to_goalimplementation inlib.rsto remove duplicate logic and handle errors correctly.lib.rsimports and removed broken inline tests.Verification
cargo testinsavings_goalsdirectory.close #62