test(savings_goals): add event emission coverage for goal lifecycle o…#120
Open
OlaGreat wants to merge 1 commit intoRemitwise-Org:mainfrom
Open
test(savings_goals): add event emission coverage for goal lifecycle o…#120OlaGreat wants to merge 1 commit intoRemitwise-Org:mainfrom
OlaGreat wants to merge 1 commit intoRemitwise-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Add event-emission test coverage for savings_goals goal lifecycle operations.
This change updates existing event tests to assert actual emitted event topics/data (not only event counts), and adds missing tests for:
FundsWithdrawn on withdraw_from_goal
GoalLocked on lock_goal
GoalUnlocked on unlock_goal
Also verifies:
GoalCreated on create_goal
FundsAdded on add_to_goal
GoalCompleted when current_amount >=target_amount