test(bill_payments): add test to owner auth to cancel_bill function#122
Open
NueloSE wants to merge 1 commit intoRemitwise-Org:mainfrom
Open
test(bill_payments): add test to owner auth to cancel_bill function#122NueloSE wants to merge 1 commit intoRemitwise-Org:mainfrom
NueloSE wants to merge 1 commit intoRemitwise-Org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add test coverage for the
cancel_billauthorization fix that was implemented in PR #115.The authorization logic (require_auth + owner verification) was already committed. This PR adds the missing test coverage.
Changes
test_cancel_bill_owner_succeeds- verifies owner can canceltest_cancel_bill_unauthorized_fails- verifies non-owner cannot cancelAcceptance Criteria
cancel_billis owner-onlyTesting
All 21 tests in bill_payments pass:

close #64