Skip to content

Comments

test(bill_payments): add test to owner auth to cancel_bill function#122

Open
NueloSE wants to merge 1 commit intoRemitwise-Org:mainfrom
NueloSE:fix/cancel-bill-owner-auth
Open

test(bill_payments): add test to owner auth to cancel_bill function#122
NueloSE wants to merge 1 commit intoRemitwise-Org:mainfrom
NueloSE:fix/cancel-bill-owner-auth

Conversation

@NueloSE
Copy link
Contributor

@NueloSE NueloSE commented Feb 23, 2026

Summary

Add test coverage for the cancel_bill authorization fix that was implemented in PR #115.

The authorization logic (require_auth + owner verification) was already committed. This PR adds the missing test coverage.

Changes

  • Added test: test_cancel_bill_owner_succeeds - verifies owner can cancel
  • Added test: test_cancel_bill_unauthorized_fails - verifies non-owner cannot cancel

Acceptance Criteria

  • cancel_bill is owner-only
  • New tests pass
  • Existing tests updated for new signature
  • Backward-compatible (all call sites already pass owner)

Testing

All 21 tests in bill_payments pass:
Screenshot 2026-02-23 at 3 48 59 AM

close #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Authorization Test for Bill cancel_bill and Fix Missing Auth

1 participant