Some quick fixes #17
Open
Some quick fixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isting info about the project in reaper_results. so calculating score again at a later point with the new found values of the attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are mainly 4 fixes made here -
fixing the score bug. The code was assigning a zero score to a project if there was no existing info in the reaper_results table on that project. Now, it's re-calculating the score at a later point with the newfound attribute values and inserting the correct score in the database.
fixing the timeout bug: It was reading timeout correctly from the config file only during the first attribute. From the second attribute, it was getting a zero value. As a quick fix, I'm hardcoding the timeout value (21600 s) in the code for now.
replaces a deprecated method for html response object.
there was a problem in installing mysql-connector-python using pip3. replaced it with an appropriate link the requirements.txt file as per the solution found in, https://stackoverflow.com/questions/34489271/i-cannot-install-mysql-connector-python-using-pip