Fix raycasts hitting gizmos #77
Conversation
I took personal offense that my mantis blade that was driven didn't work with this mod, so I fixed it.
this does what I asked it to do (first try actually!) But it doesn't do what I want. I just want objects when being grabbed not yoinking users into them if they have character parenters. I am too lazy to make a github issue it takes YDMS ages to fix litterally anything like this.
I don't like the implementation, but it will do
…ommunityBugFixCollection" This reverts commit 0ec1919, reversing changes made to 753d706.
|
oh god |
And that from you :'D @989onan you'll want to fix up that commit history though 😅 |
|
Unnecessary recomputation of ToString |
I'm not even sure what that's doing - checking for which field or such something loads? That should be done through getting the FieldInfo / MethodInfo and then using the |
|
Essentially certain IL instruction lines read stuff. Essentially I wanted to make it to where if a line is changed, a constant "74" and "95" wouldn't break if frooxius added code. Is why I am using to string hurestics so I can get the lines I wanted dynamically, then remove em and load the variables I wanted onto the stack via IL and load em into my static function. Works, but also how the code I wrote in that static function I call (thankfully not IL code) is also terrible because to find a gizmo the find component in parents doesn't work so I check for a lot above named "Gizmo" and then find the component in that component bag. What a nightmare, and there are better ways of implementing it. I just wanted working and mostly future proof. I was rushing this out the door so could hug an Avali friend (typical) |
|
Closes #76 |
These are the actual IL instructions in the common update method at the time of this PR. Essentially encompasses the if statement minus the """branch if false""" which I keep when injecting the call to my method, as to not break the if statement's jump to next IL instruction block when mine returns false to not hit the collider .(Unrelated, but this patch saved me so much headache yesterday when doing a RaycastDriver for someone last night) |
3 participants
the implementation is kinda bad, but I managed to transpile it in so the entire if statement can be manipulated.