Rename AllOf to LogicAnd
#1600
Closed
Rename AllOf to LogicAnd
#1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
=========================================
Coverage 97.43% 97.43%
Complexity 981 981
=========================================
Files 211 211
Lines 2259 2259
=========================================
Hits 2201 2201
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henriquemoody
force-pushed
the
rule/logicAnd
branch
from
4ba1cbb to
bbda727
Compare
There was a problem hiding this comment.
Pull request overview
This PR renames the AllOf validator to LogicAnd as part of version 3.0 improvements. The new name LogicAnd more clearly indicates that this is a logical AND operation where all provided rules must pass for the same input value, reducing potential confusion with iteration semantics.
Changes:
- Renamed the
AllOfclass toLogicAndand updated all internal references - Updated all mixin interfaces to replace
allOfmethods withlogicAndmethods across Builder and Chain interfaces - Updated comprehensive documentation including validator docs, feature guide, and API examples
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| library/Validators/LogicAnd.php | Renamed class from AllOf to LogicAnd |
| library/Validators/Core/Reducer.php | Updated internal usage to LogicAnd |
| library/Validators/Between.php | Updated internal usage to LogicAnd |
| library/Validators/BetweenExclusive.php | Updated internal usage to LogicAnd |
| library/ValidatorBuilder.php | Updated internal usage to LogicAnd |
| library/Transformers/Prefix.php | Updated rules list to reference logicAnd |
| library/Mixins/*.php | Updated all mixin interfaces to replace allOf with logicAnd methods |
| tests/unit/Validators/LogicAndTest.php | Renamed test file and updated all references |
| tests/unit/Validators/AllOfTest.php | Removed old test file |
| tests/unit/Validators/Core/ReducerTest.php | Updated test to use LogicAnd |
| tests/feature/Validators/LogicAndTest.php | Updated feature tests to use logicAnd method |
| docs/validators/LogicAnd.md | Updated validator documentation with new name and improved description |
| docs/validators/*.md | Updated related validator docs to reference LogicAnd |
| docs/list-of-validators-by-category.md | Updated category listings and added Logic category |
| docs/feature-guide.md | Updated grouped validation reference |
| docs/concrete-api.md | Updated API example |
| docs/validators/Control.md | Unintended change - contains a bug |
| src-dev/Commands/UpdateDocLinksCommand.php | Minor unrelated fix to remove "08-" prefix |
Comments suppressed due to low confidence (1)
docs/validators/LogicAnd.md:46
- The table separator row is inconsistently formatted. It should use spaces around the pipe character to match the formatting in the row above (line 45). The current format with dashes between pipes without spaces ("|-----:|------------------------------------------------------------------------") should be "| ------: | -------------------------------------------------------------------- |" for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The name `AllOf` was ambiguous and could be confused with iteration semantics. The new name `LogicAnd` clearly indicates this is a logical `AND` operation where all provided rules must pass for the same input value. This rename is part of a broader effort to improve the naming of composite rules in version 3.0, making them more intuitive and reducing potential confusion when implementing validation logic.
henriquemoody
force-pushed
the
rule/logicAnd
branch
from
bbda727 to
a1f007e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
AllOfwas ambiguous and could be confused with iteration semantics. The new nameLogicAndclearly indicates this is a logicalANDoperation where all provided rules must pass for the same input value.This rename is part of a broader effort to improve the naming of composite rules in version 3.0, making them more intuitive and reducing potential confusion when implementing validation logic.
Related to #1589