Skip to content

Conversation

@stiefeljackal
Copy link
Contributor

When I was working on getUsersFollowingMe, I noticed that shouldMapToBooleans was not properly mapping true or false when the API responds with those values. This bug remained undetected since almost all responses from RA's API return either a "1" or "0" for a Boolean field. Since API_GetUsersIFollow.php and API_GetUsersFollowingMe.php return either true or false for their Boolean fields, the serializer function will always map the value as false due to the missing check for true. This PR fixes this issue by adding a check for the stringified version of true.

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wescopeland wescopeland merged commit 88dae25 into RetroAchievements:main Jan 13, 2026
1 check passed
@stiefeljackal stiefeljackal deleted the fix/bool-serialization branch January 14, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants