router statistics - filter out gxs tunnels from file tunnels#109
Open
RetroPooh wants to merge 1 commit intoRetroShare:masterfrom
Open
router statistics - filter out gxs tunnels from file tunnels#109RetroPooh wants to merge 1 commit intoRetroShare:masterfrom
RetroPooh wants to merge 1 commit intoRetroShare:masterfrom
Conversation
Contributor
Contributor
|
When GXS tunnels are opened locally as client, then RsGxsNetTunnelService::mHandledHashes will contain the hash for the corresponding group_id. However, tunnels that start elsewhere will not show up here. So it all depends what this change is used for, but it will not differentiate FT tunnels to other tunnels in every case. |
csoler
reviewed
Jul 18, 2023
|
|
||
| bool RsGxsNetTunnelService::isGXSHash(RsFileHash hash) const | ||
| { | ||
| return mHandledHashes.find(hash) != mHandledHashes.end(); |
Contributor
There was a problem hiding this comment.
A mutex is missing here as you access a std::map. But having a mutex here would likely cause a deadlock randomly since you call this function from p3turtle and p3turtle is always locked after GXS tunnel and not the reverse.
Contributor
|
@RetroPooh no fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.