Skip to content

fix botan path #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
defnax wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix botan path #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libretroshare.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,8 +1187,8 @@ message("In rnp_rnplib precompilation code")
LIBRNP_CMAKE_PARAMS *= "-DJSON-C_LIBRARY=$$clean_path(/usr/local/opt/json-c/lib/libjson-c.a)"
LIBRNP_CMAKE_PARAMS *= "-DJSON-C_VERSION=0.18"
# botan
LIBRNP_CMAKE_PARAMS *= "-DBOTAN_INCLUDE_DIR=$$clean_path(/usr/local/opt/botan@2/include/botan-2)"
LIBRNP_CMAKE_PARAMS *= "-DBOTAN_LIBRARY=$$clean_path(/usr/local/opt/botan@2/lib/libbotan-2.a)"
LIBRNP_CMAKE_PARAMS *= "-DBOTAN_INCLUDE_DIR=$$clean_path(/usr/local/Cellar/botan@2/2.19.5/include/botan-2)"
Copy link
Contributor

@csoler csoler Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a MacOS specialist, but it feels not clean at all to include a version number for a system installed lib in a path.

LIBRNP_CMAKE_PARAMS *= "-DBOTAN_LIBRARY=$$clean_path(/usr/local/Cellar/botan@2/2.19.5/lib)"
# set minimum Mac Version to not get different endresults of min versions
LIBRNP_CMAKE_CXXFLAGS = -mmacosx-version-min=10.13
}
Expand Down